Skip to content

Conversation

shrikeh
Copy link
Contributor

@shrikeh shrikeh commented Apr 24, 2013

  • Updated docblock headers in lib to enhance compliance with phpdocumentor
  • Updated all spacing to match PSR-2 4 space indentation
  • Multi-line statements sorted out for compliance
  • Namespaces and use statements now compliant with newlines
  • Strings that don't require variable interpretation changed from double quote to single quote.
  • Added pedantic '' before use statements just to make it obvious it's from the root namespace.

Think that's it.

.gitignore Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason I think all these files + the IDE ones should be added to the global .gitignore files not to the project ones since they are user specific

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to strip this. I find it useful, and my IDE now inputs this into new projects automatically. Sorry about that.

@shrikeh
Copy link
Contributor Author

shrikeh commented Apr 29, 2013

As I'm sitting down for dinner and didn't want to cherry pick, I've done a fresh commit. Issues brought up should be resolved.

videlalvaro added a commit that referenced this pull request Apr 29, 2013
Fixes for full CodeSniffer PSR-2 compliance
@videlalvaro videlalvaro merged commit 0e1bd11 into php-amqplib:master Apr 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants