feat: Added doctrine/dbal v4.0. #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tasselchof Please make it compatible with PHP7.1, it's not very complicated. |
Except doctrine/dbal:^3.8 requires at least PHP 7.4, so it is impossible to do this. I think PHP 7 should be dropped from supported versions. |
leeqvip
requested changes
Apr 14, 2024
src/Adapter.php
Outdated
| @@ -97,7 +97,7 @@ public static function newAdapter($connection): Adapter | |||
| */ | |||
| public function initTable() | |||
| { | |||
| $sm = $this->connection->getSchemaManager(); | |||
| $sm = $this->connection->createSchemaManager(); | |||
There was a problem hiding this comment.
You can make some assertions here to ensure compatibility with lower versions.
src/Adapter.php
Outdated
| @@ -147,7 +147,7 @@ public function savePolicyLine($pType, array $rule) | |||
| public function loadPolicy(Model $model): void | |||
| { | |||
| $queryBuilder = $this->connection->createQueryBuilder(); | |||
| $stmt = $queryBuilder->select('p_type', 'v0', 'v1', 'v2', 'v3', 'v4', 'v5')->from($this->policyTableName)->execute(); | |||
| $stmt = $queryBuilder->select('p_type', 'v0', 'v1', 'v2', 'v3', 'v4', 'v5')->from($this->policyTableName)->executeQuery(); | |||
|
Fix: #6 |
leeqvip
requested changes
Jun 10, 2024
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #6