Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Appveyor tests #129

Merged
merged 1 commit into from
Dec 15, 2018
Merged

Fix Appveyor tests #129

merged 1 commit into from
Dec 15, 2018

Conversation

Jan-E
Copy link
Contributor

@Jan-E Jan-E commented Nov 23, 2018

@weltling @rtheunissen

See https://ci.appveyor.com/project/Jan-E/ext-ds-sv5q8/history for my failures and successes at fixing the Appveyor tests.

Caveats:

  1. Appveyor has troubles with the output of the phpunit tests. I had to redirect the output to a file and cat the file to screen afterwards.
  2. The tests with a pure minimal php.ini fail I do not know why.

@rtheunissen
Copy link
Member

Thanks for this. I'm in the process of rewriting the tests to .phpt so this should be a non-issue in the near future. 👍

@rtheunissen rtheunissen merged commit 4853616 into php-ds:master Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants