Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the documentation. #50
base: master
Are you sure you want to change the base?
Fixed the documentation. #50
Changes from all commits
a7a4770
d05e099
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is correct - it could be anything at all. See php-ds/ext-ds#140
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Man, I am so confused.
I go down the same path as many of the commenters in that thread... First, I thought
self
is correct, thenobject
, then, certainly?object
, but then you're all saying that strings, ints, floats, what else? resources, arrays and callables should also be accepted?? I'm assuming Exceptions, too? lol.I can understand
?object
, but just passing anything seems like a clear design flaw to me. But I'm very very unfamiliar w/ this project. I just wanted to do some good will and that conversation happened after I did the bulk of the changes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😁 no problem, I was for a while too. The thing here is that
equals
is used to determine equality when an object is used as a key in a hash-based structure. ie.Map
will internally call an object'sequals
method when looking up that object in the hash table.The issue is that you can of course call
equals
directly, ie.$map->equals(null)
. You can pass anything you want to that method, which means it is responsible for checking that the given arg is an instance of the same class etc. The doc comment should reflect that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regardless of the correct type, it should precede the parameter name, not come after it.