Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error on integer-value segments for Encoder #92

Open
konovalovk opened this issue Jan 4, 2019 · 2 comments
Open

Fatal error on integer-value segments for Encoder #92

konovalovk opened this issue Jan 4, 2019 · 2 comments

Comments

@konovalovk
Copy link

First of all, many thanks for your efforts!
Better to drop argument type for Encoder::escapeValue as compatibility is broken when the source array contains integers.

private function escapeValue( >>string<< &$str): string
Fatal error: Uncaught TypeError: Argument 1 passed to EDI\Encoder::escapeValue() must be of the type string, integer given

@sabas
Copy link
Collaborator

sabas commented Jan 4, 2019

You're right!
Would you like to provide a pull request?

cc @voku

voku added a commit to voku/edifact that referenced this issue Jan 6, 2019
@voku
Copy link
Contributor

voku commented Jan 6, 2019

@konovalovk can you provide a example, thanks!

PS: here is a possible fix but it needs a real world example for the tests: voku@a25a74d

stefanrosnizek added a commit to stefanrosnizek/edifact that referenced this issue Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants