Add chosen approach explanation to meta document #774
Conversation
|
@weierophinney do you think I need to add anything else to this regarding the reasoning for lambda? |
|
|
||
| Further compounding the problem is that there is no way to ensure that the | ||
| response body has not been written to, which can lead to incomplete output or | ||
| error responses being sent with cache headers attached. |
There was a problem hiding this comment.
Another issue, as detailed in a blog post by Rob Allen, is that it's difficult to get the response body into a clean state if it has been previously written to; rewinding and writing back to it can lead to issues if the new content is of shorter length than the previous. As such, developers currently must depend on a concrete StreamInterface, populate it, and pass it to generate a new response.
|
@shadowhand Provided some notes inline. 😄 |
|
@weierophinney updated based on your comments. |
| This proposal also includes a definition of a middleware stack container that | ||
| is an entry point for middleware dispatching. This interface is entirely optional | ||
| and is intended to illustrate that client middleware can be used in a server | ||
| context but server middleware cannot be used in a client context. |
There was a problem hiding this comment.
@weierophinney I've also added this description to the meta document and an additional note the StackInterface. Further comments on the ML.
There was a problem hiding this comment.
I've replied on the mailing list for this aspect.
Provide a historical record for why lambda was chosen over double pass. Refs #771
Based on feedback and recommendations for clarity.
Middleware is based on the pipeline pattern. Having more historical context is useful for understanding.
The stack container is not a critical part of the middleware proposal. Its primary purpose is to illustrate how to declare type correctly when operating in server-only, client-only, or mixed stacks.
|
Closing this. Will resubmit on a clean branch. |
Provide a historical record for why lambda was chosen over double pass.
Refs #771