PSR-17 should be available to use Symfony's HttplugClient #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm that this change fixes #149 |
|
|
xabbuh
reviewed
Dec 11, 2019
| @@ -72,7 +73,7 @@ final class CommonClassesStrategy implements DiscoveryStrategy | |||
| ['class' => React::class, 'condition' => React::class], | |||
| ], | |||
| HttpClient::class => [ | |||
| ['class' => SymfonyHttplug::class, 'condition' => SymfonyHttplug::class], | |||
| ['class' => SymfonyHttplug::class, 'condition' => [SymfonyHttplug::class, Psr17RequestFactory::class]], | |||
There was a problem hiding this comment.
Won't this possibly break applications using HttpClient 4.3 where this was not necessary?
There was a problem hiding this comment.
The HttplugClient class that this is checking for doesn't exist in HttpClient 4.3 so it shouldn't be an issue.
|
Ooops. I was too quick. It should be the message factory from HTTPlug. |
2 tasks
|
It looks like the fix was reverted by 4257709 Symfony 4.4 is still broken! |
|
did you try with discovery 1.7.2? we had to fix checks to also look at interfaces and not only classes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This is a bit of a stab in the dark, but I ran into the same problem in that issue and it seems like this PR should fix it.
Since #141 Symfony's
Symfony\Component\HttpClient\HttplugClientis the first client class attempted when using auto-discovery, with its only condition being that that specific class is available (which is true if you havesymfony/http-client >=4.4installed). However, if you don't have anything which satisfies the PSR-17 auto discovery installed, then auto-discovery as a whole is going to fail because the Symfony class can't be instantiated.This PR attempts to fix the issue by adding a condition on the PSR-17 interfaces being present as well. Looking at the Symfony app where I ran into the problem (Symfony 3.4 with the HttpClient component being pulled in as a transient dependency at 4.4), it seems like this would fix the problem because through that application's transient dependencies PSR-17 isn't installed so this condition should fail and it fall through to a working client (Guzzle in this application's case).
Checklist
To Do