fix post http request

[Bashy]

This dirty fix needs to be adapted, i just made the post http request to work, so the payment_request is retrieved from lnbits response.

Adaptations needed.

[Chemaclass]

We still might want to refactor this class and use the symfony HttpClient instead of file_get_contents()? But we can delay that decision in a follow up iteration.

[Bashy]

To be honest I took time to find a way to use Symphony HttpClient but I didn't find a way to achieve it, I agree that Symphony HttpClient might be more adapted to do the http request

[JesusValera]

Maybe in a future iteration, we can inject options directly to the HttpClient class, and we don't need to pass the $endpoint as a parameter, what do you think?

Something like:

$response = $this->httpApi->postRequestInvoice(
    body: json_encode($content, JSON_THROW_ON_ERROR),
    headers: [
        'Content-Type' => 'application/json',
        'X-Api-Key' => $this->options['api_key'],
    ],
);

[Chemaclass]

Oh, nice observation. We can try that out in a follow up iteration. What are your thoughts on this, @Bashy ?

[Bashy]

It can be done as long as we don't have any other backend type.
Other kind of LN backend will have different $endpoint, headers and body values though, which kind of structure would be the best to keep interoperability in the future?

[Chemaclass]

oh, that's right. Ok, let's keep it like it is for now. Thanks for bringing this idea up 😃

[JesusValera]

If we are not going to have so many endpoints, my suggestion is to try to have specific methods in the HttpApi for each endpoint, where each of them can "auto-solve its own dependencies" (I mean, the parameters, endpoint, etc).

It's about concreteness over abstractness in this case, but to be honest, I am still not sure about the scalability of it, it would be nice to think over it in the future 😄