Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix domain default param in config #8

Merged
merged 2 commits into from
Apr 4, 2023
Merged

fix domain default param in config #8

merged 2 commits into from
Apr 4, 2023

Conversation

Bashy
Copy link
Collaborator

@Bashy Bashy commented Apr 3, 2023 •
edited
Loading

📚 Description

domain itself should not have protocol information, it leads to have double protocol in callback url

🔖 Changes

removed https:// from default domain value

@Bashy
fix domain default param in config
807115f 
domain itself should not have protocol information
@Bashy Bashy requested a review from Chemaclass April 3, 2023 21:02
@Bashy Bashy self-assigned this Apr 3, 2023
@Chemaclass Chemaclass merged commit daf31f4 into main Apr 4, 2023
@Chemaclass Chemaclass deleted the config-domain-fix branch April 4, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chemaclass Chemaclass Chemaclass approved these changes

Assignees

@Bashy Bashy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bashy @Chemaclass @JesusValera