Skip to content

Conversation

chalasr
Copy link
Contributor

@chalasr chalasr commented Oct 16, 2022

Allows playing with https://github.com/dunglas/frankenphp-demo with PHP 8.1 installed locally and without need to tweak the README instructions. Otherwise:

Screenshot 2022-10-16 at 15 38 36

Let's revisit this only once php 8.2 stable gets released.

@chalasr chalasr changed the title [FrankenPHP] Relax php requirement - allow 8.1 [FrankenPHP] Relax php requirement - allow 8.0 Oct 16, 2022
@chalasr
Copy link
Contributor Author

chalasr commented Oct 16, 2022

Lowered to >=8.0 as it makes the CI happy and requires zero code change.

@dunglas
Copy link
Contributor

dunglas commented Oct 16, 2022

I'm not sure it's worth it because FrankenPHP doesn't work at all with PHP <8.2 (and only with a patched version of 8.2).

If you want to test locally on 8.x before running the code in FrankenPHP, you can do composer install --ignore-platform-req=php

@chalasr
Copy link
Contributor Author

chalasr commented Oct 16, 2022

and only with a patched version of 8.2

Isn't it embedded in FrankenPHP anyway? I hesitated to rather add the ignore-platform-req flag to the demo's install instructions but realized that the PHP on which FrankenPHP runs doesn't matter for people using this runtime (just trying to improve the checkout experience while it's hot so that you get more segfaults to fix! :p)

@dunglas
Copy link
Contributor

dunglas commented Oct 16, 2022

Works for me!

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm merged commit 3eb94a7 into php-runtime:main Oct 17, 2022
@chalasr chalasr deleted the frankenphp-8.1 branch October 17, 2022 08:13
@chalasr
Copy link
Contributor Author

chalasr commented Oct 26, 2022

A tag would be much appreciated when you have a chance 🙏

@Nyholm
Copy link
Member

Nyholm commented Oct 26, 2022

https://github.com/php-runtime/frankenphp-symfony/releases/tag/0.1.1

@chalasr
Copy link
Contributor Author

chalasr commented Oct 26, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants