-
-
Notifications
You must be signed in to change notification settings - Fork 34
Adding Swoole's Server mode and settings #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Swoole's Server mode and settings #59
Conversation
@ad3n this isn't merged yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely. This is great.
Could you add a small test to it?
Sure, I will think on something this weekend. |
@Nyholm I think this is it. <testsuite name="E2E">
<directory>./tests/E2E</directory>
</testsuite> added. I wasn't sure how to add a working server to the CI for the E2E, but Unit tests covers 100%. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done with the tests!
Isn't all test suites running by default? Ie, we are already running E2E on the CI?
Thanks! All test suites will run, but on the php tests/E2E/runtime.php Then: phpunit --testsuit E2E I guess that to put on the CI, it is probably something that runtime's directory structure should agree with, like having a |
Great. Thank you. Let's improve CI later. |
Closes #58 by