Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix WP_REST_Request::offsetExists #176

Merged
merged 1 commit into from
May 12, 2024
Merged

fix WP_REST_Request::offsetExists #176

merged 1 commit into from
May 12, 2024

Conversation

szepeviktor
Copy link
Member

@szepeviktor szepeviktor commented May 12, 2024 •
edited
Loading

@IanDelMar Would it fix @phpstan-param @param key-of<T> $offset?

Discovered in szepeviktor/phpstan-wordpress#219

@szepeviktor
Copy link
Member Author

BTW Pascal broken the Internet! (again)
https://github.com/php-stubs/wordpress-stubs/pull/66/files#diff-d4861ed4fac1ec7ef9c2ae151070735460cc8f0a75976569973dd073375114cfR56 @swissspidy

swissspidy
swissspidy approved these changes May 12, 2024
View reviewed changes
Copy link
Contributor

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops good catch

@szepeviktor szepeviktor merged commit c209138 into master May 12, 2024
0 of 2 checks passed
@szepeviktor szepeviktor deleted the szepeviktor-patch-3 branch May 12, 2024 10:52
@szepeviktor szepeviktor mentioned this pull request May 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szepeviktor @swissspidy