Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firstAirDateYear() sent as year, not first_air_date_year #27

Closed
NChief opened this issue Jun 3, 2014 · 5 comments
Closed

firstAirDateYear() sent as year, not first_air_date_year #27

NChief opened this issue Jun 3, 2014 · 5 comments
Assignees

Comments

@NChief
Copy link
Contributor

NChief commented Jun 3, 2014

in \Tmdb\Model\Search\SearchQuery\TvSearchQuery()
this
$this->set('year', (int) $year);
should be
$this->set('first_air_date_year', (int) $year);

according to http://docs.themoviedb.apiary.io/#search and my own tests.

@wtfzdotnet
Copy link
Member

I'll get back to you tomorrow or Thursday, sorry my schedule is quite full lately! :-) if you could possibly make a pull request if your sure I'll merge it in no time when I have a chance to look at it!

@wtfzdotnet
Copy link
Member

And thanks for reporting by the way =)

@wtfzdotnet
Copy link
Member

Took a quick look at the docs and current code from my bed, and your absolutely right, I don't use all aspects of the api myself. If you could make a pull request that would be awesome, credits belong to you for finding that mistake.

@NChief
Copy link
Contributor Author

NChief commented Jun 4, 2014

I have created a pull request now. hope it is correct, its my first pull request ever :P

wtfzdotnet added a commit that referenced this issue Jun 4, 2014
fixes #27 first_air_date_year in TvSearchQuery
@wtfzdotnet
Copy link
Member

It was absolutely fine :-), thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants