-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalise cURL documentation #137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this contribution. Instead of commiting the suggestions I added some more. ;) Apart of missing newlines at the end of the files it looks good to me.
2ecfa5c
to
ca540f4
Compare
@msamesch Thanks for your detailed review. I appreciate it very much! I think I will translate more documentation parts in the future. In any case, now I know more precisely what to pay attention to (for example, a newline at the end of the file). I have accordingly adjusted the last points and cleaned up the commit history and pushed the whole thing here. |
@joshuaruesweg Great! If you intent to contribute more, you could also consider to become a member of the translation team. I would greatly appreciate it. I forgot to mention (I'm sorry), that the EN-Revision tag is missing (right after the line <$xml version....), that is: |
ca540f4
to
67d56b2
Compare
@msamesch I have added the revision tag! :) |
@joshuaruesweg Thanks! |
This Pull-Request finalise the translation of the cURL documentation.
Note: This is my first translation for the PHP documentation. So feel free to point out stylistic errors (or errors in general) to me.
I am also unsure if I should have opened a pull request for each file here, or if this is ok.