Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalise cURL documentation #137

Merged
merged 18 commits into from
Jul 9, 2023
Merged

Conversation

joshuaruesweg
Copy link
Member

@joshuaruesweg joshuaruesweg commented Jul 8, 2023

This Pull-Request finalise the translation of the cURL documentation.

Note: This is my first translation for the PHP documentation. So feel free to point out stylistic errors (or errors in general) to me.

I am also unsure if I should have opened a pull request for each file here, or if this is ok.

@joshuaruesweg joshuaruesweg marked this pull request as ready for review July 8, 2023 10:49
@msamesch msamesch self-assigned this Jul 8, 2023
Copy link
Contributor

@msamesch msamesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this contribution. Instead of commiting the suggestions I added some more. ;) Apart of missing newlines at the end of the files it looks good to me.

@joshuaruesweg joshuaruesweg force-pushed the curl-documentation branch 2 times, most recently from 2ecfa5c to ca540f4 Compare July 9, 2023 11:06
@joshuaruesweg
Copy link
Member Author

@msamesch Thanks for your detailed review. I appreciate it very much! I think I will translate more documentation parts in the future. In any case, now I know more precisely what to pay attention to (for example, a newline at the end of the file).

I have accordingly adjusted the last points and cleaned up the commit history and pushed the whole thing here.

@msamesch
Copy link
Contributor

msamesch commented Jul 9, 2023

@joshuaruesweg Great! If you intent to contribute more, you could also consider to become a member of the translation team. I would greatly appreciate it. I forgot to mention (I'm sorry), that the EN-Revision tag is missing (right after the line <$xml version....), that is:
<!-- EN-Revision: REVISION NUMBER Maintainer: YOU Status: ready -->
The EN-Rev can be obtained from Documentation Tools
If you want, I'll add them.

@joshuaruesweg
Copy link
Member Author

@msamesch I have added the revision tag! :)

@msamesch
Copy link
Contributor

msamesch commented Jul 9, 2023

@joshuaruesweg Thanks!

@msamesch msamesch merged commit d2635ab into php:master Jul 9, 2023
@joshuaruesweg joshuaruesweg deleted the curl-documentation branch July 9, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants