Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translations: language/predefined #148

Merged
merged 9 commits into from
Jul 30, 2023
Merged

Add translations: language/predefined #148

merged 9 commits into from
Jul 30, 2023

Conversation

msamesch
Copy link
Contributor

@msamesch msamesch commented Jul 23, 2023

It finally worked as intended. :-)

@msamesch msamesch changed the title Add translations: language/predefined (draft) Add translations: language/predefined Jul 26, 2023
language/predefined/generator/current.xml Outdated Show resolved Hide resolved
language/predefined/generator/throw.xml Outdated Show resolved Hide resolved
</para>
<para>
Wenn der Generator beim Aufruf dieser Methode bereits geschlossen ist, wird
die Exception stattdessen im Kontext des aufrufenden Codes geworfen.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, the word "Exception" does not need to be translated. But above (within Fiber::isTerminated) you have translated this word with "Ausnahme". We should keep this consistent here.

I would replace "Ausnahme" with "Exception" above (within Fiber::isTerminated).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me too. Deepl always translates it.

language/predefined/internaliterator/construct.xml Outdated Show resolved Hide resolved
language/predefined/internaliterator/valid.xml Outdated Show resolved Hide resolved
language/predefined/internaliterator/valid.xml Outdated Show resolved Hide resolved
language/predefined/internaliterator/valid.xml Outdated Show resolved Hide resolved
msamesch and others added 6 commits July 30, 2023 18:56
Co-authored-by: Joshua Rüsweg <josh@wcflabs.de>
Co-authored-by: Joshua Rüsweg <josh@wcflabs.de>
Co-authored-by: Joshua Rüsweg <josh@wcflabs.de>
OMG ;-)

Co-authored-by: Joshua Rüsweg <josh@wcflabs.de>
Co-authored-by: Joshua Rüsweg <josh@wcflabs.de>
Co-authored-by: Joshua Rüsweg <josh@wcflabs.de>
@msamesch
Copy link
Contributor Author

Thanks a lot. Obviously I need more coffee. ;-)

@msamesch msamesch merged commit 66513ea into master Jul 30, 2023
1 check passed
@msamesch msamesch deleted the predefined2-draft branch July 30, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants