Add missing param/return value sections #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
commented
Mar 13, 2022
| <para> | ||
| <variablelist> | ||
| <varlistentry> | ||
| <term><parameter>name</parameter></term> |
There was a problem hiding this comment.
I wonder if this shouldn't be changed in php-src as it's weird it's the only one called name instead of attribute.
Girgias
force-pushed
the
qa-section-order-script-fix
branch
from
bed45bc
to
13ffc7d
Compare
|
Seems OK to me. Is there anything blocking a merge? |
cmb69
reviewed
Mar 30, 2022
Girgias
force-pushed
the
qa-section-order-script-fix
branch
from
13ffc7d
to
e9167fd
Compare
cmb69
approved these changes
Apr 2, 2022
tiffany-taylor
pushed a commit
to tiffany-taylor/doc-en
that referenced
this pull request
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This, with #1457, fixes the remain (current) issues raised by the section order QA script #658.
After merging both of them we should add the check to CI so that a PR can't introduce section ordering issues.