Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update string.xml to remove old string interpolation #2712

Merged
merged 1 commit into from
Aug 26, 2023
Merged

Conversation

kohler
Copy link
Contributor

@kohler kohler commented Aug 26, 2023

An example used the deprecated ${varname} syntax; fix it.

An example used the deprecated `${varname}` syntax; fix it.
@adoy
Copy link
Member

adoy commented Aug 26, 2023

Thanks

@adoy adoy merged commit 48e35e9 into php:master Aug 26, 2023
2 checks passed
@kohler kohler deleted the patch-1 branch August 26, 2023 16:56
@salathe
Copy link
Contributor

salathe commented Aug 28, 2023

👎 The example that was changed is now in the wrong section of that page. It is now an example of the "Complex (curly) syntax" but the example is within the "Simple syntax" section.

@kohler
Copy link
Contributor Author

kohler commented Aug 28, 2023

What's your preferred fix? Complex syntax is the only non-deprecated way to handle the example.

@adoy
Copy link
Member

adoy commented Aug 28, 2023

@salathe You're right my bad. Thanks for catching this, I went to fast without paying attention.

I guess we should remove the part from this example that uses the complex syntax (the 3rd echo) and add this example in the complex curly syntax.

@Girgias
Copy link
Member

Girgias commented Aug 30, 2023

I was working on a rewrite of this whole page in #2000 as it was not a straightforward fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants