Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise "open source" capitalisation #2731

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

timacdonald
Copy link
Contributor

I don't have strong feelings on if this should be capitalised or not, but I do think we should reference it consistently.

I appears 8 times throughout the docs. Only two are capitalised.

Additionally, a similar sentence on the Preface and Getting Started pages uses differing casing.

Screen Shot 2023-09-02 at 1 13 30 pm Screen Shot 2023-09-02 at 1 13 40 pm

@Girgias Girgias added the QA Quality Assurance label Sep 2, 2023
@Girgias Girgias added this to the QA improvements milestone Sep 2, 2023
@Girgias
Copy link
Member

Girgias commented Sep 2, 2023

Going to wait before merging this to wait for translations to catch up with some large markup changes.

@salathe
Copy link
Contributor

salathe commented Sep 4, 2023

There is also 1 usage of open-source present in security/database.xml.

@salathe
Copy link
Contributor

salathe commented Sep 4, 2023

This might also be worth adding to the Style guidelines (source).

@Girgias Girgias merged commit 95b8f4d into php:master Apr 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Quality Assurance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants