Incorrect regex for floating point numbers #2735
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From manual page: https://www.php.net/manual/en/language.types.float.php Fixed Issue php#2711
Girgias
reviewed
Sep 2, 2023
| @@ -29,7 +29,7 @@ $d = 1_234.567; // as of PHP 7.4.0 | |||
| <programlisting> | |||
| <![CDATA[ | |||
| LNUM [0-9]+(_[0-9]+)* | |||
| DNUM ([0-9]*(_[0-9]+)*[\.]{LNUM}) | ({LNUM}[\.][0-9]*(_[0-9]+)*) | |||
| DNUM (([0-9]+(_[0-9]+)*)?\.{LNUM}) | ({LNUM}\.([0-9]+(_[0-9]+)*)?) | |||
There was a problem hiding this comment.
Why are the ? needed? Shouldn't they be covered with the * quantifier?
There was a problem hiding this comment.
The ? allows numbers of the form: .123 or 123.
([0-9]+(_[0-9]+)*)? prohibits the use of the separator _ at the beginning and at the end of the number.
_123 or 123_ are incorrect.
There was a problem hiding this comment.
[0-9]*(_[0-9]+)* allows the separator _ at the beginning (this is a mistake).
There was a problem hiding this comment.
Can't it be written as {LNUM}?\.{LNUM} | {LNUM}\.{LNUM}? then?
There was a problem hiding this comment.
This form of regex is more compact and looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Issue #2711
Above issue talks about replacing the DNUM regex:
DNUM ([0-9]*(_[0-9]+)*[\.]{LNUM}) | ({LNUM}[\.][0-9]*(_[0-9]+)*)with:
DNUM (([0-9]+(_[0-9]+)*)?\.{LNUM}) | ({LNUM}\.([0-9]+(_[0-9]+)*)?)In this PR required changes are done.