Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncronize predefined constants with stubs - part 1 #2739

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

kocsismate
Copy link
Member

This is the beginning PR for syncronizing predefined constants with stubs. For now, the changes only affect formatting, and mostly are whitespace changes.

@saundefined
Copy link
Member

For doc-ru I try to keep track of whitespaces and so, I guess for most of the files I will just update EN-Revision
(or we can merge it with skip-revcheck).

So LGTM, but let's see what others say

@mumumu
Copy link
Member

mumumu commented Sep 4, 2023

For doc-ja, almost changes of this PR can be applied without rejecting by patch(1), so LGTM for me too.

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering it is only whitespace changes I will merge this with a skip-revcheck tag

@Girgias Girgias merged commit 5e9500d into php:master Sep 4, 2023
2 checks passed
@Girgias
Copy link
Member

Girgias commented Sep 4, 2023

Also kinda related to #649

@kocsismate kocsismate deleted the stub-prefefined-const-sync1 branch September 5, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants