Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize list of predefined constants with stubs - part 5 #2744

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

kocsismate
Copy link
Member

@kocsismate kocsismate commented Sep 5, 2023

No description provided.

@kocsismate kocsismate changed the title Synchronize list of reserved constants with stubs Synchronize list of predefined constants with stubs - part 5 Sep 5, 2023
@Girgias
Copy link
Member

Girgias commented Sep 6, 2023

Could you spin out the whitespace only change into a different PR that can be skipped by revcheck? as I didn't see the core INI file initially had a change

@kocsismate
Copy link
Member Author

kocsismate commented Sep 12, 2023

Could you spin out the whitespace only change into a different PR that can be skipped by revcheck?

I created two commits instead in this PR: first one fixes the indentation as well as trailing whitespaces, and the second one synchronizes the actual content.

Please note that it became possible to automatically update table based predefined constant pages in the meantime, so now there are a few more pages to sync...

@Girgias Girgias merged commit 3728053 into php:master Sep 13, 2023
2 checks passed
@kocsismate kocsismate deleted the stub-predefined-constants5 branch September 13, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants