$message in stream_notification_callback() is nullable #2767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaze
added a commit
to spaze/michalspacek.cz
that referenced
this pull request
Sep 13, 2023
…back I had it right in MichalSpacekCz\Http\HttpStreamContext::create(), which probably should be used instead, but followed the example in PHP docs that says only `string $message`. PHP docs PR php/doc-en#2767 Introduced in bd8c089 in #220
spaze
added a commit
to spaze/michalspacek.cz
that referenced
this pull request
Sep 13, 2023
…back I had it right in MichalSpacekCz\Http\HttpStreamContext::create(), which probably should be used instead, but followed the example in PHP docs that says only `string $message`. PHP docs PR php/doc-en#2767 Introduced in bd8c089 in #220
spaze
added a commit
to spaze/michalspacek.cz
that referenced
this pull request
Sep 13, 2023
…` callback (#222) I had it right in `MichalSpacekCz\Http\HttpStreamContext::create()`, which probably should be used instead, but followed the example in PHP docs that says only `string $message`. PHP docs PR php/doc-en#2767 Introduced in bd8c089 in #220
Girgias
requested changes
Sep 16, 2023
There was a problem hiding this comment.
This is not the markup of how a union type is written.
But the change is correct.
@kocsismate I wonder what we should do with those pages, as there are no stubs/interfaces for custom streams or related functions
|
Oh, I'm sorry I messed it up. Corrected the markup. |
Girgias
approved these changes
Sep 16, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least for HTTP streams, the
$messageparameter ofstream_notification_callback()is nullable, let's document it.See https://onlinephp.io/c/f0a2fc for a simple script to get the types.