compact() now issues an E_WARNING error.(PHP8.0)
#2776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since PHP 8.0: "A number of notices have been converted into warnings" related to: https://www.php.net/manual/en/migration80.incompatible.php php/php-src@c37a1cd
Girgias
approved these changes
Sep 19, 2023
|
Thanks! I corrected the markup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PHP 8.0: "A number of notices have been converted into warnings"
Usually, in the PHP manual, even if the error level is raised from E_NOTICE to E_WARNING, a changelog isn't kept within individual function pages.
However, on the compact() page, there's already an entry in the changelog regarding the previous change to 'now issues an E_NOTICE'. Therefore, I believe that adding a note explicitly indicating the recent change in the issued error might prevent confusion.