modernize ErrorException example code #2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMO the old example should have been set_error_handler(__NAMESPACE__ . "\\exception_error_handler"); so it would work in any namespace, instead of just working in the global namespace, and crash-at-runtime if used in any other namespace, but as of PHP8.1.0 we have an even better way to do it: set_error_handler(exception_error_handler(...));
Girgias
reviewed
Sep 22, 2023
Girgias
reviewed
Sep 22, 2023
Co-authored-by: George Peter Banyard <girgias@php.net>
Girgias
reviewed
Sep 23, 2023
That was actually fixing a consistency issue - other parts of the documentation uses the variable names I switched to here. (Am on phone right now so cba finding out where in the docs, but shouldn't be hard to find) Edit: I think it's the set_error_handler documentation. |
Girgias
reviewed
Sep 25, 2023
Right, consistency is best. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO the old example should have been
so it would work in any namespace, because the old example just worked in the global namespace, and crashed-at-runtime if used in any other namespace, but as of PHP8.1.0 we have an even better way to do it: set_error_handler(exception_error_handler(...));