Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update descriptions of octal, hex and unicode escape sequences #2793

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Update descriptions of octal, hex and unicode escape sequences #2793

merged 2 commits into from
Sep 26, 2023

Conversation

boxcleverliam
Copy link
Contributor

Clarify which part of each sequence is the regular expression by repeating it in the description, and give examples of each. Before this change, the curly braces are confusing due to having two different meanings in these sequences.

Clarify which part of each sequence is the regular expression by repeating it in the description, and give examples of each. Before this change, the curly braces are confusing due to having two different meanings in these sequences.
language/types/string.xml Outdated Show resolved Hide resolved
@Girgias Girgias linked an issue Sep 26, 2023 that may be closed by this pull request
@Girgias Girgias merged commit 3a13ca3 into php:master Sep 26, 2023
2 checks passed
@Girgias
Copy link
Member

Girgias commented Sep 26, 2023

Thank you!

@boxcleverliam boxcleverliam deleted the patch-1 branch September 26, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strings Escaped characters section uses {} inconsistently, unclear
2 participants