Add MongoDB\BSON\Binary::TYPE_SENSITIVE constant #2939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
changed the title
Girgias
reviewed
Nov 14, 2023
reference/mongodb/bson/binary.xml
Outdated
| <varlistentry xml:id="mongodb-bson-binary.constants.type-sensitive"> | ||
| <term><constant>MongoDB\BSON\Binary::TYPE_SENSITIVE</constant></term> | ||
| <listitem> | ||
| <para>Sensitive data. This subtype is used for sensitive data that should be excluded from server-side logging when possible.</para> |
There was a problem hiding this comment.
Nit for ease of translators.
Suggested change
| <para>Sensitive data. This subtype is used for sensitive data that should be excluded from server-side logging when possible.</para> | |
| <para> | |
| Sensitive data. | |
| This subtype is used for sensitive data that should be excluded from server-side logging when possible. | |
| </para> |
There was a problem hiding this comment.
Thanks. I re-wrapped the text in an amended commit.
I considered fixing the wrapping on other, existing constants but that'd be beyond the scope of this PR and would likely only add more work for translators (assuming that content has already been translated).
alcaeus
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-2267
Split this off from #2938 since it relates to an unmerged PR: mongodb/mongo-php-driver#1488