Update return values for floor() function
#3007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
requested changes
Dec 12, 2023
reference/math/functions/cos.xml
Outdated
Comment on lines
42
to
64
| <refsect1 role="changelog"> | ||
| &reftitle.changelog; | ||
| <informaltable> | ||
| <tgroup cols="2"> | ||
| <thead> | ||
| <row> | ||
| <entry>&Version;</entry> | ||
| <entry>&Description;</entry> | ||
| </row> | ||
| </thead> | ||
| <tbody> | ||
| <row> | ||
| <entry>8.0.0</entry> | ||
| <entry> | ||
| <parameter>num</parameter> no longer accepts internal objects which support | ||
| numeric conversion. Previous to this version, this function returns &false; | ||
| in case of an error and an <constant>E_WARNING</constant> error is emitted. | ||
| </entry> | ||
| </row> | ||
| </tbody> | ||
| </tgroup> | ||
| </informaltable> | ||
| </refsect1> |
There was a problem hiding this comment.
This is invalid, it never supported internal objects.
reference/math/functions/ceil.xml
Outdated
| @@ -57,7 +57,8 @@ | |||
| <entry>8.0.0</entry> | |||
| <entry> | |||
| <parameter>num</parameter> no longer accepts internal objects which support | |||
| numeric conversion. | |||
| numeric conversion. Previous to this version, this function returns &false; | |||
| in case of an error and an <constant>E_WARNING</constant> error is emitted. | |||
There was a problem hiding this comment.
An E_WARNING is not always emitted, an E_NOTICE is emitted for objects see: https://3v4l.org/SGfsd a warning is only emitted for non-numeric strings as far as I can tell.
And other types such as arrays do not emit any diagnostic at all: https://3v4l.org/FCHmh
Moreover, I consider those to be ZPP/Type failures and something we do not document.
phansys
force-pushed
the
math
branch
2 times, most recently
from
86f5732
to
97af202
Compare
phansys
changed the title
floor() function
Thanks for the feedback. |
Girgias
approved these changes
Dec 12, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.