Rewrite MySQLnd statistic page #3357
Conversation
Girgias
force-pushed
the
mysqlnd-docbook
branch
from
b21f688
to
599f0fa
Compare
|
Thanks, I am in the process of reviewing this but there are a lot of changes here and it has raised many questions for me. I hope to get back to you with something tomorrow or the day after tomorrow. |
No worries, I also had many questions while rewriting this and expected this to take a while to review :) |
There was a problem hiding this comment.
Thank you for this PR. I appreciate how much work you have put into this. I like how the page looks now and I am happy with most of your changes. I have highlighted some typos and answered your TODOs. I have also left some TODOs for myself as I investigate these statistics. I'll need some time to do this and in the meantime you can fix the issues I identified.
I have a gripe with this whole feature. I would love it if we could deprecate the statistics and remove them soon. I think I lost some of my sanity while reading this page. But that is off-topic.
| <!-- TODO: XInclude/sync description of INI setting | ||
| ini.mysqlnd.net-cmd-buffer-size with this statistic --> |
There was a problem hiding this comment.
So, when I had a link at the INI setting description it was just a copy paste from it, so the INI setting description might need a rewrite, which is why I put that TODO comment here
|
Thank you for the review! I tried to address each review comment in a separate commit so it's easy to figure out what changed. Still missing a couple as it seemed you needed to think about them some more. :) |
|
Made the suggested changes |
|
@kamil-tekiela do you have any more comments? I would like to merge this sooner than later. |
- Remove personalization - Improve document structure - DocBook 5.2 conformance
This reverts commit 2f7be48.
This is probably easier by comparing to the actual live page: https://www.php.net/manual/en/mysqlnd.stats.php
The only things that really ought to be looked at, are my
TODOcomments.