Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add global DATE format constants to constants list #3512

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Add global DATE format constants to constants list #3512

merged 4 commits into from
Jul 9, 2024

Conversation

haszi
Copy link
Contributor

@haszi haszi commented Jun 29, 2024

Part of #2747.

Girgias
Girgias requested changes Jul 7, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue with the indentation.

I'm also wondering if the resulting examples should be in a <literal> tag or not.

reference/datetime/constants.xml Outdated Show resolved Hide resolved
reference/datetime/constants.xml Outdated Show resolved Hide resolved
@haszi haszi requested a review from Girgias July 8, 2024 18:55
@Girgias Girgias merged commit d31dda8 into php:master Jul 9, 2024
2 checks passed
@haszi haszi deleted the Add-global-DATE-format-constants-to-the-constant-list branch July 9, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

@derickr derickr Awaiting requested review from derickr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haszi @Girgias