Skip to content

Commit 05a884f

Browse files
twosenikic
authored andcommitted
Optimize MySQL statement execute without parameters
1 parent aa376cc commit 05a884f

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

ext/mysqlnd/mysqlnd_ps_codec.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -938,7 +938,7 @@ mysqlnd_stmt_execute_generate_request(MYSQLND_STMT * const s, zend_uchar ** requ
938938
zend_uchar *p = stmt->execute_cmd_buffer.buffer,
939939
*cmd_buffer = stmt->execute_cmd_buffer.buffer;
940940
size_t cmd_buffer_length = stmt->execute_cmd_buffer.length;
941-
enum_func_status ret;
941+
enum_func_status ret = PASS;
942942

943943
DBG_ENTER("mysqlnd_stmt_execute_generate_request");
944944

@@ -955,7 +955,9 @@ mysqlnd_stmt_execute_generate_request(MYSQLND_STMT * const s, zend_uchar ** requ
955955
int1store(p, 1); /* and send 1 for iteration count */
956956
p+= 4;
957957

958-
ret = mysqlnd_stmt_execute_store_params(s, &cmd_buffer, &p, &cmd_buffer_length);
958+
if (stmt->param_count != 0) {
959+
ret = mysqlnd_stmt_execute_store_params(s, &cmd_buffer, &p, &cmd_buffer_length);
960+
}
959961

960962
*free_buffer = (cmd_buffer != stmt->execute_cmd_buffer.buffer);
961963
*request_len = (p - cmd_buffer);

0 commit comments

Comments
 (0)