Release temporary string reference

sgolemon · sgolemon · commit 24030d54d86e · 2017-06-25T19:39:13.000-04:00
diff --git a/ext/intl/dateformat/dateformat_create.cpp b/ext/intl/dateformat/dateformat_create.cpp
@@ -216,7 +216,9 @@ U_CFUNC PHP_METHOD( IntlDateFormatter, __construct )
 	return_value = getThis();
 	if (datefmt_ctor(INTERNAL_FUNCTION_PARAM_PASSTHRU, 1) == FAILURE) {
 		if (!EG(exception)) {
-			zend_throw_exception(IntlException_ce_ptr, ZSTR_VAL(intl_error_get_message(NULL)), intl_error_get_code(NULL));
+			zend_string *err = intl_error_get_message(NULL);
+			zend_throw_exception(IntlException_ce_ptr, ZSTR_VAL(err), intl_error_get_code(NULL));
+			zend_string_release(err);
 		}
 	}
 	zend_restore_error_handling(&error_handling);

Original file line number	Diff line number	Diff line change
`@@ -216,7 +216,9 @@ U_CFUNC PHP_METHOD( IntlDateFormatter, __construct )`
`216`	`216`	`return_value = getThis();`
`217`	`217`	`if (datefmt_ctor(INTERNAL_FUNCTION_PARAM_PASSTHRU, 1) == FAILURE) {`
`218`	`218`	`if (!EG(exception)) {`
`219`		`- zend_throw_exception(IntlException_ce_ptr, ZSTR_VAL(intl_error_get_message(NULL)), intl_error_get_code(NULL));`
	`219`	`+ zend_string *err = intl_error_get_message(NULL);`
	`220`	`+ zend_throw_exception(IntlException_ce_ptr, ZSTR_VAL(err), intl_error_get_code(NULL));`
	`221`	`+ zend_string_release(err);`
`220`	`222`	`}`
`221`	`223`	`}`
`222`	`224`	`zend_restore_error_handling(&error_handling);`