Swap implode() argument order in some tests

nikic · nikic · commit 2e56e14e39ee · 2019-07-12T12:54:10.000+02:00
diff --git a/ext/spl/tests/arrayObject_getIteratorClass_basic1.phpt b/ext/spl/tests/arrayObject_getIteratorClass_basic1.phpt
@@ -6,36 +6,36 @@ class MyIterator extends ArrayIterator {
 
 	function __construct() {
 	 	$args = func_get_args();
-		echo "   In " . __METHOD__ . "(" . implode($args, ',') . ")\n";
+		echo "   In " . __METHOD__ . "(" . implode(',', $args) . ")\n";
 	}
 
 	function rewind() {
 		$args = func_get_args();
-		echo "   In " . __METHOD__ . "(" . implode($args, ',') . ")\n";
+		echo "   In " . __METHOD__ . "(" . implode(',', $args) . ")\n";
 		return parent::rewind();
 	}
 
 	function valid() {
 		$args = func_get_args();
-		echo "   In " . __METHOD__ . "(" . implode($args, ',') . ")\n";
+		echo "   In " . __METHOD__ . "(" . implode(',', $args) . ")\n";
 		return parent::valid();
 	}
 
 	function current() {
 		$args = func_get_args();
-		echo "   In " . __METHOD__ . "(" . implode($args, ',') . ")\n";
+		echo "   In " . __METHOD__ . "(" . implode(',', $args) . ")\n";
 		return parent::current();
 	}
 
 	function next() {
 		$args = func_get_args();
-		echo "   In " . __METHOD__ . "(" . implode($args, ',') . ")\n";
+		echo "   In " . __METHOD__ . "(" . implode(',', $args) . ")\n";
 		return parent::next();
 	}
 
 	function key() {
 		$args = func_get_args();
-		echo "   In " . __METHOD__ . "(" . implode($args, ',') . ")\n";
+		echo "   In " . __METHOD__ . "(" . implode(',', $args) . ")\n";
 		return parent::key();
 	}
 }
diff --git a/ext/spl/tests/arrayObject_magicMethods5.phpt b/ext/spl/tests/arrayObject_magicMethods5.phpt
@@ -16,19 +16,19 @@ class UsesMagic extends ArrayObject {
 
 	function __get($name) {
 		$args = func_get_args();
-		echo "In " . __METHOD__ . "(" . implode($args, ',') . ")\n";
+		echo "In " . __METHOD__ . "(" . implode(',', $args) . ")\n";
 	}
 	function __set($name, $value) {
 		$args = func_get_args();
-		echo "In " . __METHOD__ . "(" . implode($args, ',') . ")\n";
+		echo "In " . __METHOD__ . "(" . implode(',', $args) . ")\n";
 	}
 	function __isset($name) {
 		$args = func_get_args();
-		echo "In " . __METHOD__ . "(" . implode($args, ',') . ")\n";
+		echo "In " . __METHOD__ . "(" . implode(',', $args) . ")\n";
 	}
 	function __unset($name) {
 		$args = func_get_args();
-		echo "In " . __METHOD__ . "(" . implode($args, ',') . ")\n";
+		echo "In " . __METHOD__ . "(" . implode(',', $args) . ")\n";
 	}
 
 }
diff --git a/tests/basic/precision.phpt b/tests/basic/precision.phpt
@@ -13,7 +13,7 @@ ini_set('serialize_precision', -1);
 echo ini_get('precision'), PHP_EOL;
 echo ini_get('serialize_precision'), PHP_EOL;
 echo "OUTPUTS".PHP_EOL;
-echo join($v, ' ').PHP_EOL;
+echo join(' ', $v).PHP_EOL;
 var_dump(serialize($v));
 var_export($v);echo PHP_EOL;
 
@@ -24,7 +24,7 @@ ini_set('serialize_precision', 0);
 echo ini_get('precision'), PHP_EOL;
 echo ini_get('serialize_precision'), PHP_EOL;
 echo "OUTPUTS".PHP_EOL;
-echo join($v, ' ').PHP_EOL;
+echo join(' ', $v).PHP_EOL;
 var_dump(serialize($v));
 var_export($v);echo PHP_EOL;
 
@@ -34,7 +34,7 @@ ini_set('serialize_precision', 9);
 echo ini_get('precision'), PHP_EOL;
 echo ini_get('serialize_precision'), PHP_EOL;
 echo "OUTPUTS".PHP_EOL;
-echo join($v, ' ').PHP_EOL;
+echo join(' ', $v).PHP_EOL;
 var_dump(serialize($v));
 var_export($v);echo PHP_EOL;
 
@@ -44,7 +44,7 @@ ini_set('serialize_precision', 14);
 echo ini_get('precision'), PHP_EOL;
 echo ini_get('serialize_precision'), PHP_EOL;
 echo "OUTPUTS".PHP_EOL;
-echo join($v, ' ').PHP_EOL;
+echo join(' ', $v).PHP_EOL;
 var_dump(serialize($v));
 var_export($v);echo PHP_EOL;
 
@@ -54,7 +54,7 @@ ini_set('serialize_precision', 17);
 echo ini_get('precision'), PHP_EOL;
 echo ini_get('serialize_precision'), PHP_EOL;
 echo "OUTPUTS".PHP_EOL;
-echo join($v, ' ').PHP_EOL;
+echo join(' ', $v).PHP_EOL;
 var_dump(serialize($v));
 var_export($v);echo PHP_EOL;
 
@@ -64,7 +64,7 @@ ini_set('serialize_precision', 25);
 echo ini_get('precision'), PHP_EOL;
 echo ini_get('serialize_precision'), PHP_EOL;
 echo "OUTPUTS".PHP_EOL;
-echo join($v, ' ').PHP_EOL;
+echo join(' ', $v).PHP_EOL;
 var_dump(serialize($v));
 var_export($v);echo PHP_EOL;
 
@@ -74,7 +74,7 @@ ini_set('serialize_precision', 100);
 echo ini_get('precision'), PHP_EOL;
 echo ini_get('serialize_precision'), PHP_EOL;
 echo "OUTPUTS".PHP_EOL;
-echo join($v, ' ').PHP_EOL;
+echo join(' ', $v).PHP_EOL;
 var_dump(serialize($v));
 var_export($v);echo PHP_EOL;
 --EXPECT--

Original file line number	Diff line number	Diff line change
`@@ -6,36 +6,36 @@ class MyIterator extends ArrayIterator {`
`6`	`6`
`7`	`7`	`function __construct() {`
`8`	`8`	`$args = func_get_args();`
`9`		`- echo " In " . __METHOD__ . "(" . implode($args, ',') . ")\n";`
	`9`	`+ echo " In " . __METHOD__ . "(" . implode(',', $args) . ")\n";`
`10`	`10`	`}`
`11`	`11`
`12`	`12`	`function rewind() {`
`13`	`13`	`$args = func_get_args();`
`14`		`- echo " In " . __METHOD__ . "(" . implode($args, ',') . ")\n";`
	`14`	`+ echo " In " . __METHOD__ . "(" . implode(',', $args) . ")\n";`
`15`	`15`	`return parent::rewind();`
`16`	`16`	`}`
`17`	`17`
`18`	`18`	`function valid() {`
`19`	`19`	`$args = func_get_args();`
`20`		`- echo " In " . __METHOD__ . "(" . implode($args, ',') . ")\n";`
	`20`	`+ echo " In " . __METHOD__ . "(" . implode(',', $args) . ")\n";`
`21`	`21`	`return parent::valid();`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`function current() {`
`25`	`25`	`$args = func_get_args();`
`26`		`- echo " In " . __METHOD__ . "(" . implode($args, ',') . ")\n";`
	`26`	`+ echo " In " . __METHOD__ . "(" . implode(',', $args) . ")\n";`
`27`	`27`	`return parent::current();`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`function next() {`
`31`	`31`	`$args = func_get_args();`
`32`		`- echo " In " . __METHOD__ . "(" . implode($args, ',') . ")\n";`
	`32`	`+ echo " In " . __METHOD__ . "(" . implode(',', $args) . ")\n";`
`33`	`33`	`return parent::next();`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`function key() {`
`37`	`37`	`$args = func_get_args();`
`38`		`- echo " In " . __METHOD__ . "(" . implode($args, ',') . ")\n";`
	`38`	`+ echo " In " . __METHOD__ . "(" . implode(',', $args) . ")\n";`
`39`	`39`	`return parent::key();`
`40`	`40`	`}`
`41`	`41`	`}`
Original file line number	Diff line number	Diff line change
`@@ -16,19 +16,19 @@ class UsesMagic extends ArrayObject {`
`16`	`16`
`17`	`17`	`function __get($name) {`
`18`	`18`	`$args = func_get_args();`
`19`		`- echo "In " . __METHOD__ . "(" . implode($args, ',') . ")\n";`
	`19`	`+ echo "In " . __METHOD__ . "(" . implode(',', $args) . ")\n";`
`20`	`20`	`}`
`21`	`21`	`function __set($name, $value) {`
`22`	`22`	`$args = func_get_args();`
`23`		`- echo "In " . __METHOD__ . "(" . implode($args, ',') . ")\n";`
	`23`	`+ echo "In " . __METHOD__ . "(" . implode(',', $args) . ")\n";`
`24`	`24`	`}`
`25`	`25`	`function __isset($name) {`
`26`	`26`	`$args = func_get_args();`
`27`		`- echo "In " . __METHOD__ . "(" . implode($args, ',') . ")\n";`
	`27`	`+ echo "In " . __METHOD__ . "(" . implode(',', $args) . ")\n";`
`28`	`28`	`}`
`29`	`29`	`function __unset($name) {`
`30`	`30`	`$args = func_get_args();`
`31`		`- echo "In " . __METHOD__ . "(" . implode($args, ',') . ")\n";`
	`31`	`+ echo "In " . __METHOD__ . "(" . implode(',', $args) . ")\n";`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`}`