Private methods don't have to be duplicated

dstogov · dstogov · commit 36b7021e2cd0 · 2019-06-26T13:27:13.000+03:00
diff --git a/Zend/zend_inheritance.c b/Zend/zend_inheritance.c
@@ -70,7 +70,8 @@ static zend_function *zend_duplicate_function(zend_function *func, zend_class_en
 		if (func->op_array.refcount) {
 			(*func->op_array.refcount)++;
 		}
-		if (EXPECTED(!func->op_array.static_variables)) {
+		if (EXPECTED(!func->op_array.static_variables)
+		 || (func->op_array.fn_flags & ZEND_ACC_PRIVATE)) {
 			/* reuse the same op_array structure */
 			return func;
 		}

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,8 @@ static zend_function zend_duplicate_function(zend_function func, zend_class_en`
`70`	`70`	`if (func->op_array.refcount) {`
`71`	`71`	`(*func->op_array.refcount)++;`
`72`	`72`	`}`
`73`		`- if (EXPECTED(!func->op_array.static_variables)) {`
	`73`	`+ if (EXPECTED(!func->op_array.static_variables)`
	`74`	`+ \|\| (func->op_array.fn_flags & ZEND_ACC_PRIVATE)) {`
`74`	`75`	`/* reuse the same op_array structure */`
`75`	`76`	`return func;`
`76`	`77`	`}`