Skip to content

Commit

Permalink
Clarify that location is required in do_request
Browse files Browse the repository at this point in the history
As far as I can tell, the location is always non-null here,
and the code wouldn't be able to meaningfully work without a
location.
  • Loading branch information
nikic committed Feb 10, 2021
1 parent cff35ca commit 40ba9f6
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions ext/soap/soap.c
Original file line number Diff line number Diff line change
Expand Up @@ -2215,11 +2215,7 @@ static int do_request(zval *this_ptr, xmlDoc *request, char *location, char *act

ZVAL_STRINGL(&func,"__doRequest",sizeof("__doRequest")-1);
ZVAL_STRINGL(&params[0], buf, buf_size);
if (location == NULL) {
ZVAL_NULL(&params[1]);
} else {
ZVAL_STRING(&params[1], location);
}
ZVAL_STRING(&params[1], location);
if (action == NULL) {
ZVAL_NULL(&params[2]);
} else {
Expand Down Expand Up @@ -2371,6 +2367,7 @@ static void do_soap_call(zend_execute_data *execute_data,

if (location == NULL) {
location = binding->location;
ZEND_ASSERT(location);
}
if (binding->bindingType == BINDING_SOAP) {
sdlSoapBindingFunctionPtr fnb = (sdlSoapBindingFunctionPtr)fn->bindingAttributes;
Expand Down

0 comments on commit 40ba9f6

Please sign in to comment.