Set up asan+ubsan scheduled build on azure

nikic · nikic · commit 54dd762f596d · 2019-06-28T15:00:54.000+02:00
Also adds an --asan flag to run-tests.php to setup all the necessary
environment variables. Some tests are marked as skipped because they
are incompatible with asan or too slow.

I'm basing this on the DEBUG_ZTS build, which seems to give us the
most mileage.
diff --git a/Zend/tests/concat_003.phpt b/Zend/tests/concat_003.phpt
@@ -1,7 +1,10 @@
 --TEST--
 Concatenating many small strings should not slowdown allocations
 --SKIPIF--
-<?php if (PHP_DEBUG) { die ("skip debug version is slow"); } ?>
+<?php
+if (PHP_DEBUG) { die ("skip debug version is slow"); }
+if (getenv('SKIP_PERF_SENSITIVE')) die("skip performance sensitive test");
+?>
 --FILE--
 <?php
 
diff --git a/azure-pipelines.yml b/azure-pipelines.yml
@@ -55,3 +55,12 @@ jobs:
       parameters:
         configurationName: MACOS_RELEASE_ZTS
         configurationParameters: '--disable-debug --enable-maintainer-zts'
+    - template: azure/job.yml
+      parameters:
+        configurationName: DEBUG_ZTS_ASAN_UBSAN
+        configurationParameters: >-
+            --enable-debug --enable-maintainer-zts
+            CFLAGS='-fsanitize=undefined,address -DZEND_TRACK_ARENA_ALLOC'
+            LDFLAGS='-fsanitize=undefined,address'
+        runTestsParameters: --asan
+        timeoutInMinutes: 120
diff --git a/azure/job.yml b/azure/job.yml
@@ -1,9 +1,12 @@
 parameters:
   configurationName: ''
   configurationParameters: ''
+  runTestsParameters: ''
+  timeoutInMinutes: 60
 
 jobs:
   - job: ${{ parameters.configurationName }}
+    timeoutInMinutes: ${{ parameters.timeoutInMinutes }}
     pool:
       vmImage: 'ubuntu-latest'
     steps:
@@ -80,8 +83,11 @@ jobs:
     - template: test.yml
       parameters:
         configurationName: ${{ parameters.configurationName }}
+        runTestsParameters: ${{ parameters.runTestsParameters }}
     - template: test.yml
       parameters:
         configurationName: ${{ parameters.configurationName }}
         runTestsName: 'OpCache'
-        runTestsParameters: -d zend_extension=opcache.so -d opcache.enable_cli=1
+        runTestsParameters: >-
+          ${{ parameters.runTestsParameters }}
+          -d zend_extension=opcache.so -d opcache.enable_cli=1
diff --git a/azure/lsan-suppressions.txt b/azure/lsan-suppressions.txt
@@ -0,0 +1 @@
+leak:acommon::DictInfoList::elements
diff --git a/ext/fileinfo/tests/cve-2014-3538-nojit.phpt b/ext/fileinfo/tests/cve-2014-3538-nojit.phpt
@@ -4,6 +4,8 @@ Bug #66731: file: extensive backtraking, with pcre.jit=0
 <?php
 if (defined("PHP_DEBUG") && PHP_DEBUG)
 	die("skip not suitable for debug build");
+if (getenv('SKIP_PERF_SENSITIVE'))
+    die("skip performance sensitive test");
 if (!class_exists('finfo'))
 	die('skip no fileinfo extension');
 ?>
diff --git a/ext/opcache/tests/log_verbosity_bug.phpt b/ext/opcache/tests/log_verbosity_bug.phpt
@@ -12,7 +12,10 @@ opcache.file_cache_fallback=0
 opcache.memory_consumption=999999999
 opcache.log_verbosity_level=-1
 --SKIPIF--
-<?php require_once('skipif.inc'); ?>
+<?php
+require_once('skipif.inc');
+if (getenv('SKIP_ASAN')) die('xfail Startup failure leak');
+?>
 --FILE--
 <?php
 var_dump("Script should fail");
diff --git a/ext/opcache/tests/preload_006.phpt b/ext/opcache/tests/preload_006.phpt
@@ -6,7 +6,10 @@ opcache.enable_cli=1
 opcache.optimization_level=-1
 opcache.preload={PWD}/preload_inheritance_error_ind.inc
 --SKIPIF--
-<?php require_once('skipif.inc'); ?>
+<?php
+require_once('skipif.inc');
+if (getenv('SKIP_ASAN')) die('xfail Startup failure leak');
+?>
 --FILE--
 <?php
 echo "Foobar\n";
diff --git a/ext/pcntl/tests/pcntl_unshare_02.phpt b/ext/pcntl/tests/pcntl_unshare_02.phpt
@@ -6,6 +6,7 @@ if (!extension_loaded("pcntl")) die("skip");
 if (!extension_loaded("posix")) die("skip posix extension not available");
 if (!function_exists("pcntl_unshare")) die("skip pcntl_unshare is not available");
 if (!defined("CLONE_NEWPID")) die("skip flag unavailable");
+if (getenv("SKIP_ASAN")) die("skip asan chokes on this");
 if (posix_getuid() !== 0 &&
     (!defined("CLONE_NEWUSER") ||
     (pcntl_unshare(CLONE_NEWUSER) == false && pcntl_get_last_error() == PCNTL_EPERM))) {
diff --git a/ext/pcre/tests/bug72685.phpt b/ext/pcre/tests/bug72685.phpt
@@ -1,5 +1,9 @@
 --TEST--
 Bug #72685: Same string is UTF-8 validated repeatedly
+--SKIPIF--
+<?php
+if (getenv('SKIP_PERF_SENSITIVE')) die("skip performance sensitive test");
+?>
 --FILE--
 <?php
 
diff --git a/ext/pspell/tests/005.phpt b/ext/pspell/tests/005.phpt
@@ -4,6 +4,7 @@ pspell configs
 <?php
 if (!extension_loaded('pspell')) die('skip');
 if (!@pspell_new('en')) die('skip English dictionary is not available');
+if (getenv('SKIP_ASAN')) die('skip pspell leaks memory for invalid dicationaries');
 ?>
 --FILE--
 <?php
diff --git a/ext/standard/tests/general_functions/get_cfg_var_variation8.phpt b/ext/standard/tests/general_functions/get_cfg_var_variation8.phpt
@@ -5,6 +5,8 @@ Francesco Fullone ff@ideato.it
 #PHPTestFest Cesena Italia on 2009-06-20
 --INI--
 magic_quotes_gpc=1
+--SKIPIF--
+<?php if (getenv('SKIP_ASAN')) die('xfail Startup failure leak'); ?>
 --FILE--
 <?php
 echo "*** Test by calling method or function with deprecated option ***\n";
diff --git a/ext/xsl/tests/bug33853.phpt b/ext/xsl/tests/bug33853.phpt
@@ -1,7 +1,10 @@
 --TEST--
 Bug #33853 (php:function call __autoload with lowercase param)
 --SKIPIF--
-<?php if (!extension_loaded('xsl')) die('skip xsl not loaded'); ?>
+<?php
+if (!extension_loaded('xsl')) die('skip xsl not loaded');
+if (getenv('SKIP_ASAN')) die('xfail bailing out across foreign C code');
+?>
 --FILE--
 <?php
 
diff --git a/run-tests.php b/run-tests.php
@@ -517,6 +517,18 @@ function main()
 					case '--shuffle':
 						$shuffle = true;
 						break;
+					case '--asan':
+						$environment['USE_ZEND_ALLOC'] = 0;
+						$environment['USE_TRACKED_ALLOC'] = 1;
+						$environment['SKIP_ASAN'] = 1;
+						$environment['SKIP_PERF_SENSITIVE'] = 1;
+
+						$lsanSuppressions = __DIR__ . '/azure/lsan-suppressions.txt';
+						if (file_exists($lsanSuppressions)) {
+							$environment['LSAN_OPTIONS'] = 'suppressions=' . $lsanSuppressions
+								. ':print_suppressions=0';
+						}
+						break;
 					//case 'w'
 					case '-':
 						// repeat check with full switch
diff --git a/sapi/cli/tests/upload_2G.phpt b/sapi/cli/tests/upload_2G.phpt
@@ -25,6 +25,10 @@ if (empty($enough_free_ram)) {
 if (getenv('TRAVIS')) {
     die("skip Fails intermittently on travis");
 }
+
+if (getenv('SKIP_PERF_SENSITIVE')) {
+    die("skip Test may be very slow if PHP is instrumented");
+}
 ?>
 --FILE--
 <?php
diff --git a/sapi/fpm/tests/bug68381-log-level-warning.phpt b/sapi/fpm/tests/bug68381-log-level-warning.phpt
@@ -3,6 +3,7 @@ FPM: bug68381 - Log messages with warning level only
 --SKIPIF--
 <?php
 include "skipif.inc";
+if (getenv("SKIP_ASAN")) die("skip Often fails on azure with asan for unknown reason");
 ?>
 --FILE--
 <?php
diff --git a/sapi/phpdbg/tests/watch_001.phpt b/sapi/phpdbg/tests/watch_001.phpt
@@ -5,6 +5,9 @@ Test simple recursive watchpoint
 if (PHP_INT_SIZE == 4) {
     die("xfail There may be flaws in the implementation of watchpoints that cause failures");
 }
+if (getenv('SKIP_ASAN')) {
+    die("skip intentionally causes segfaults");
+}
 ?>
 --INI--
 opcache.optimization_level=0
diff --git a/sapi/phpdbg/tests/watch_002.phpt b/sapi/phpdbg/tests/watch_002.phpt
@@ -5,6 +5,9 @@ Test simple array watchpoint with replace
 if (PHP_INT_SIZE == 4) {
     die("xfail There may be flaws in the implementation of watchpoints that cause failures");
 }
+if (getenv('SKIP_ASAN')) {
+    die("skip intentionally causes segfaults");
+}
 ?>
 --PHPDBG--
 b 6
diff --git a/sapi/phpdbg/tests/watch_003.phpt b/sapi/phpdbg/tests/watch_003.phpt
@@ -5,6 +5,9 @@ Test simple watchpoint with replace
 if (PHP_INT_SIZE == 4) {
     die("xfail There may be flaws in the implementation of watchpoints that cause failures");
 }
+if (getenv('SKIP_ASAN')) {
+    die("skip intentionally causes segfaults");
+}
 ?>
 --PHPDBG--
 b 6
diff --git a/sapi/phpdbg/tests/watch_004.phpt b/sapi/phpdbg/tests/watch_004.phpt
@@ -5,6 +5,9 @@ Test detection of inline string manipulations on zval watch
 if (PHP_INT_SIZE == 4) {
     die("xfail There may be flaws in the implementation of watchpoints that cause failures");
 }
+if (getenv('SKIP_ASAN')) {
+    die("skip intentionally causes segfaults");
+}
 ?>
 --INI--
 opcache.optimization_level=0
diff --git a/sapi/phpdbg/tests/watch_005.phpt b/sapi/phpdbg/tests/watch_005.phpt
@@ -5,6 +5,9 @@ Test proper watch comparisons when having multiple levels of indirection from a
 if (PHP_INT_SIZE == 4) {
     die("xfail There may be flaws in the implementation of watchpoints that cause failures");
 }
+if (getenv('SKIP_ASAN')) {
+    die("skip intentionally causes segfaults");
+}
 ?>
 --PHPDBG--
 b 3
diff --git a/sapi/phpdbg/tests/watch_006.phpt b/sapi/phpdbg/tests/watch_006.phpt
@@ -5,6 +5,9 @@ Test multiple watch elements pointing to the same watchpoint
 if (PHP_INT_SIZE == 4) {
     die("xfail There may be flaws in the implementation of watchpoints that cause failures");
 }
+if (getenv('SKIP_ASAN')) {
+    die("skip intentionally causes segfaults");
+}
 ?>
 --PHPDBG--
 b 4
