Make a copy unconditionally

weltling · weltling · commit 68c34ce0dcf2 · 2018-09-09T10:42:53.000+02:00
diff --git a/ext/pcre/php_pcre.c b/ext/pcre/php_pcre.c
@@ -739,7 +739,7 @@ PHPAPI pcre_cache_entry* pcre_get_compiled_regex_cache(zend_string *regex)
 				efree(pattern);
 				return NULL;
 			}
-			_k = zend_string_dup(BG(locale_string), 1);
+			_k = zend_string_init(ZSTR_VAL(BG(locale_string)), ZSTR_LEN(BG(locale_string)), 1);
 			zend_hash_add_ptr(&char_tables, _k, (void *)tables);
 			zend_string_release(_k);
 		}

Original file line number	Diff line number	Diff line change
`@@ -739,7 +739,7 @@ PHPAPI pcre_cache_entry* pcre_get_compiled_regex_cache(zend_string *regex)`
`739`	`739`	`efree(pattern);`
`740`	`740`	`return NULL;`
`741`	`741`	`}`
`742`		`- _k = zend_string_dup(BG(locale_string), 1);`
	`742`	`+ _k = zend_string_init(ZSTR_VAL(BG(locale_string)), ZSTR_LEN(BG(locale_string)), 1);`
`743`	`743`	`zend_hash_add_ptr(&char_tables, _k, (void *)tables);`
`744`	`744`	`zend_string_release(_k);`
`745`	`745`	`}`