Fix emory leak

Fixes oss-fuzz #44408
php · Feb 11, 2022 · 73fed0f · 73fed0f
1 parent a506b00
commit 73fed0f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/Zend/tests/closure_063.phpt b/Zend/tests/closure_063.phpt
@@ -0,0 +1,12 @@
+--TEST--
+Closure::bindTo leaks with "fake" closure
+--FILE--
+<?php
+function foo(){
+    static $y;
+}
+Closure::fromCallable('foo')->bindTo(new stdClass);
+?>
+DONE
+--EXPECT--
+DONE
diff --git a/Zend/zend_closures.c b/Zend/zend_closures.c
@@ -770,7 +770,8 @@ static void zend_create_closure_ex(zval *res, zend_function *func, zend_class_en
 
 ZEND_API void zend_create_closure(zval *res, zend_function *func, zend_class_entry *scope, zend_class_entry *called_scope, zval *this_ptr)
 {
-	zend_create_closure_ex(res, func, scope, called_scope, this_ptr, /* is_fake */ false);
+	zend_create_closure_ex(res, func, scope, called_scope, this_ptr,
+		/* is_fake */ (func->common.fn_flags & ZEND_ACC_FAKE_CLOSURE) != 0);
 }
 
 ZEND_API void zend_create_fake_closure(zval *res, zend_function *func, zend_class_entry *scope, zend_class_entry *called_scope, zval *this_ptr) /* {{{ */