Skip to content

Commit

Permalink
Fix GH-8578: Error on wrong parameter on SoapHeader constructor
Browse files Browse the repository at this point in the history
Closes GH-8579.
  • Loading branch information
robertnisipeanu authored and cmb69 committed May 19, 2022
1 parent 84ea0aa commit 8735ae9
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions NEWS
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ PHP NEWS
. Fixed bug GH-8466 (ini_get() is optimized out when the option does not
exist). (Arnaud)

- Soap:
. Fixed bug GH-8578 (Error on wrong parameter on SoapHeader constructor).
(robertnisipeanu)

- SPL:
. Fixed bug GH-8235 (iterator_count() may run indefinitely). (cmb)

Expand Down
2 changes: 1 addition & 1 deletion ext/soap/soap.c
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,7 @@ PHP_METHOD(SoapHeader, __construct)
if (ZSTR_LEN(actor_str) > 2) {
add_property_stringl(this_ptr, "actor", ZSTR_VAL(actor_str), ZSTR_LEN(actor_str));
} else {
zend_argument_value_error(2, "must be longer than 2 characters");
zend_argument_value_error(5, "must be longer than 2 characters");
RETURN_THROWS();
}
} else if (!actor_is_null) {
Expand Down

0 comments on commit 8735ae9

Please sign in to comment.