Avoid string allocation in dom_get_dom1_attribute() for as long as po…

…ssible
php · Jul 13, 2023 · 9880c33 · 9880c33
1 parent 66e2aa7
commit 9880c33
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/ext/dom/element.c b/ext/dom/element.c
@@ -159,18 +159,17 @@ static xmlNodePtr dom_get_dom1_attribute(xmlNodePtr elem, xmlChar *name) /* {{{
 	nqname = xmlSplitQName3(name, &len);
 	if (nqname != NULL) {
 		xmlNsPtr ns;
-		xmlChar *prefix = xmlStrndup(name, len);
-		if (prefix && xmlStrEqual(prefix, (xmlChar *)"xmlns")) {
+		if (strncmp((const char *) name, "xmlns:", len + 1) == 0) {
 			ns = elem->nsDef;
 			while (ns) {
 				if (xmlStrEqual(ns->prefix, nqname)) {
 					break;
 				}
 				ns = ns->next;
 			}
-			xmlFree(prefix);
 			return (xmlNodePtr)ns;
 		}
+		xmlChar *prefix = xmlStrndup(name, len);
 		ns = xmlSearchNs(elem->doc, elem, prefix);
 		if (prefix != NULL) {
 			xmlFree(prefix);