Skip to content

Commit 990a404

Browse files
weltlingweltling
committed
Add test for bug #76738
Original repro. It's unwieldy, but it's otherwise hard to trigger the wrong buffer handling behavior.
1 parent 0414fff commit 990a404

File tree

1 file changed

+234
-0
lines changed

1 file changed

+234
-0
lines changed

‎ext/dom/tests/bug76738.phpt‎

Lines changed: 234 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,234 @@
1+
--TEST--
2+
Bug #76738 Wrong handling of output buffer
3+
--SKIPIF--
4+
<?php require_once('skipif.inc'); ?>
5+
--FILE--
6+
<?php declare(strict_types=1);
7+
$test_string = base64_decode('PGRpdiBjbGFzcz0idGlueW1jZS1nZW5lcmF0ZWQtcm9vdC1ibG9jayIgc3R5bGU9Im1hcmdpbjogMHB4OyBwYWRkaW5nOiAwcHg7Ij4KPGRpdiBzdHlsZT0iZmxvYXQ6IHJpZ2h0OyI+PGltZyBhbHQ9IkZvdG8gUmVpbmRsIEhhcmFsZCIgc3JjPSIvcnRlL3VwbG9hZC9mb3RvLmpwZyIgc3R5bGU9IndpZHRoOiAyNTBweDsgaGVpZ2h0OiAyNDlweDsiPjwvZGl2Pgo8ZGl2IHN0eWxlPSJ3aGl0ZS1zcGFjZTogbm93cmFwOyI+CjxwIHN0eWxlPSJtYXJnaW46IDBweDsiPlJlaW5kbCBIYXJhbGQmdXVtbDs8YnI+IFNpZWdmcmllZGdhc3NlIDIyLTI0LzIvNDxicj4gMTIxMCBXaWVuPGJyPiAoKzQzKSAwNjc2IDQwIDIyMSA0MDxicj4gW2JlZm9yZWxpbmtzXTxhIGhyZWY9Ii9zaG93X2NvbnRlbnQucGhwP3NpZD0xMDciPnN1cHBvcnRAcmhzb2Z0Lm5ldDwvYT48YnI+IFtiZWZvcmVsaW5rc108YSBocmVmPSIvcmVpbmRsLWhhcmFsZC52Y2YiPlYtQ2FyZCBoZXJ1bnRlcmxhZGVuPC9hPjxicj4gW2JlZm9yZWxpbmtzXTxhIHRhcmdldD0iX2JsYW5rIiBocmVmPSIvZ3BnL3N1cHBvcnRfcmhzb2Z0Lm5ldC5wdWIudHh0Ij5NYWlsIEdQRy1LZXk8L2E+PC9wPgo8L2Rpdj4KPGRpdiBzdHlsZT0iZmxvYXQ6IG5vbmU7IHBhZGRpbmctdG9wOiAxNXB4OyI+Cjxocj4KPGI+R2VidXJ0c2RhdHVtOiA8L2I+MTIuIE5vdmVtYmVyIDE5NzcsIE1pc3RlbGJhY2gsIE4mT3VtbDsKPGg0PkJFUlVGU0VSRkFIUlVORzwvaDQ+CjxoNT4xOTkzIC0gMjAwMCBJbmcuIEdpbmRsIEdtYkggMjEyMCBXb2xrZXJzZG9yZjwvaDU+Cjx1bD4KPGxpPk1vbnRhZ2UgdW5kIFdhcnR1bmcgdm9uICZvdW1sO2ZmZW50bGljaGVuIEJlbGV1Y2h0dW5nZW48L2xpPgo8bGk+V2FydHVuZyB1bmQgRXJyaWNodHVuZyB2b24gU2lnbmFsYW5sYWdlbjwvbGk+CjxsaT5Xb2huYmF1LUluc3RhbGxhdGlvbmVuPC9saT4KPGxpPkluZnJhc3RydWt0dXJhdXNiYXUgaW4gWnVzYW1tZW5hcmJlaXQgbWl0IGRlciBFVk4gTmllZGVyJm91bWw7c3RlcnJlaWNoPC9saT4KPC91bD4KPGRpdiBjbGFzcz0idGlueW1jZS1nZW5lcmF0ZWQtcm9vdC1ibG9jayIgc3R5bGU9Im1hcmdpbjogMHB4OyBwYWRkaW5nOiAwcHg7Ij4KPGg1PjIwMDEgLSAyMDAyIE4mT3VtbDsgVm9sa3NoaWxmZSAyMTMwIE1pc3RlbGJhY2g8L2g1Pgo8L2Rpdj4KPHVsPgo8bGk+RWxla3Ryb2luc3RhbGxhdGlvbiwgVGVjaG5pc2NoZXIgU3VwcG9ydDwvbGk+CjwvdWw+CjxoNT4yMDAxIC0gMjAwNyBFaW56ZWx1bnRlcm5laG1lcjwvaDU+Cjx1bD4KPGxpPkVudHdpY2tsdW5nIHZvbiBEYXRlbmJhbmstTCZvdW1sO3N1bmdlbiwgSW50ZXJuZXQvSW50cmFuZXQtQXBwbGlrYXRpb25lbjwvbGk+CjxsaT5OZXR6d2Vyay0gdW5kIFNlcnZlcnRlY2huaWs8L2xpPgo8bGk+Q29udGVudC1NYW5hZ21lbnQtU3lzdGVtZTwvbGk+CjxsaT5FLUJ1c2luZXNzPC9saT4KPC91bD4KPGg1PnNlaXQgMjAwODwvaDU+Cjx1bD4KPGxpPjxhIGhyZWY9Imh0dHA6Ly93d3cudGhlbG91bmdlLm5ldC8iIHRhcmdldD0icmh3aW4iIG9uY2xpY2s9InJod2luZm9jdXMoKTsiPnRoZWxvdW5nZSBpbnRlcmFjdGl2ZSBkZXNpZ248L2E+PC9saT4KPGxpPlNvZnR3YXJlLUVudHdpY2tsdW5nPC9saT4KPGxpPlRlY2huaXNjaGUgQWRtaW5pc3RyYXRpb248L2xpPgo8L3VsPgo8aHI+CjxoND5LVVJTRSBVTkQgU0NIVUxVTkdFTjwvaDQ+Cjx1bD4KPGxpPjEwLjA4LiAtIDA5LjEwLjIwMDIgTWljcm9zb2Z0IENlcnRpZmllZCBQcm9mZXNzaW9uYWw8L2xpPgo8bGk+MjkuMDYuIC0gMDkuMDguMjAwMiBXaW5kb3dzIDIwMDAgSW5zdGFsbGF0aW9uIHVuZCBWZXJ3YWx0dW5nPC9saT4KPGxpPjIxLjA1LiAtIDI4LjA2LjIwMDIgV2luZG93cyBOVCA0LjAgVGVjaG5pc2NoZXMgS25vd0hvdyAxLTQ8L2xpPgo8bGk+MjEuMDUuIC0gMjguMDYuMjAwMiBFaW5mJnV1bWw7aHJ1bmcgaW4gTmV0endlcmt0ZWNobm9sb2dpZSAxLTI8L2xpPgo8bGk+MTMuMDIuIC0gMjIuMDUuMjAwMSBFdXJvcCZhdW1sO2lzY2hlciBDb21wdXRlcmYmdXVtbDtocmVyc2NoZWluIChFQ0RMKTwvbGk+CjxsaT4wNS4wMy4gLSAwNi4wNC4yMDAxIEF1cy0gdW5kIFdlaXRlcmJpbGR1bmcgaW0gVmVya2F1ZjwvbGk+CjwvdWw+Cjxocj4KPGg0PkFVU0JJTERVTkc8L2g0Pgo8dWw+CjxsaT4xOTg0IC0gMTk4OCBWb2xrc3NjaHVsZTwvbGk+CjxsaT4xOTg4IC0gMTk5MiBIYXVwdHNjaHVsZTwvbGk+CjxsaT4xOTkyIC0gMTk5MyBQb2x5dGVjaG5pc2NoZXIgTGVocmdhbmcgKE1pdCBBdXN6ZWljaG51bmcpPC9saT4KPGxpPjE5OTMgLSAxOTk3IExhbmRlc2JlcnVmc3NjaHVsZSAoTWl0IEF1c3plaWNobnVuZyk8L2xpPgo8L3VsPgo8aHI+CjxoND5JTlRFUkVTU0VOPC9oND4KPHVsPgo8bGk+TXVzaWssIEtpbm8sIDxhIGhyZWY9Imh0dHA6Ly93d3cua2FyYW9rZS13aWVuLmF0LyIgdGFyZ2V0PSJfYmxhbmsiIHRpdGxlPSJCYWJ1ZGVyJnJzcXVvO3MgfCBNYWNoIGRpZSBXZWx0IHp1IGRlaW5lciBCJnV1bWw7aG5lIHwgS2FyYW9rZSBpbiBXaWVuOiI+S2FyYW9rZTwvYT4KPC9saT4KPGxpPlNwb3J0IHNvZmVybmUgZXMgZGllIEZyZWl6ZWl0IHVuZCBkYXMgV2V0dGVyIHp1bGFzc2VuPC9saT4KPGxpPkVEViB1bmQgSW5mb3JtYXRpb25zdGVjaG5vbG9naWUgYXVjaCBwcml2YXQ8L2xpPgo8bGk+VW50ZXJoYWx0dW5nZWxla3Ryb25payBqZWdsaWNoZXIgQXJ0PC9saT4KPGxpPlNvZnR3YXJlLUVudHdpY2tsdW5nIG1pdCBWaXN1YWwgQmFzaWMgNi4wIHp1ciBwcml2YXRlbiBWZXJ3ZW5kdW5nPC9saT4KPGxpPlRlc3RlbiB2b24gU3lzdGVtZW4gdW5kIE5ldHplcmtlbiBpbSBwcml2YXRlbiB1bmQgZ2VzY2gmYXVtbDtmdGxpY2hlbiBVbWZlbGQ8L2xpPgo8bGk+SW50ZXJuZXQtUHJvZ3JhbW1pZXJ1bmcgKEphdmFTY3JpcHQgLyBDU1MgLyBQSFAgLyBNeVNRTCk8L2xpPgo8bGk+QXVkaW8tIHVuZCBCaWxkYmVhcmJlaXR1bmc8L2xpPgo8L3VsPgo8aHI+CjxoND5NVVNJSzwvaDQ+Cjx1bD4KPGxpPkhlYXZ5LU1ldGFsLCBSb2NrLCBLdXNjaGVsLVJvY2ssIE9sZGllcywgQXVzdHJvLVBvcDwvbGk+CjxsaT5EZWVwIFB1cnBsZSwgSm9lIEx5bm4gVHVybmVyLCBJYW4gR2lsbGFuLCBEZWYgTGVwcGFyZCwgQWVyb3NtaXRoLCBBQy9EQywgRG9ybywgQiZvdW1sO2hzZSBPbmtlbHosIE1ldGFsbGljYSwgR3VucyBOJmFjdXRlOyBSb3NlcywgSnVkYXMgUHJpZXN0LCBIZWxsb3dlZW4sIEtJU1MsIEFsaWNlIENvb3BlciwgQmxhY2sgU2FiYmF0aCwgTWFub3dhciwgTWFnbnVtLCBTYXZhdGFnZSwgVmljdG9yeSwgTGVkIFplcHBlbGluLCBHbGVubiBIdWdoZXMsIE51IFBhZ2FkaTwvbGk+CjxsaT5Kb2FuYSBaaW1tZXIsIFBldGVyIENldGVyYSwgQnJ5YW4gQWRhbXMsIFRvdG8sIFF1ZWVuLCBSRU0sIEV1cm9wZSwgU2NvcnBpb25zLCBXaGl0ZSBMaW9uLCBNZWF0IExvYWYsIEJvbiBKb3ZpLCBEaXJlIFN0cmFpdHMsIFJveGV0dGUsIENoaWNhZ28sIFNhbnRhbmEsIFN0YXR1cyBRdW8sIFN1cnZpdm9yLCBGb3JlaWduZXIsIEJvc3RvbiwgQm9uZmlyZSwgUmFpbmJvdywgR2VuZXNpcywgUG9pc29uLCBKb2huIE5vcnVtLCBSYWVtb25uPC9saT4KPGxpPlNUUywgSGVyYmVydCBHciZvdW1sO25lbXllciwgT3B1cywgRmFsY28sIFRvdGVuIEhvc2VuLCBXb2xmZ2FuZyBBbWJyb3MsIEEzLCBQZXRlciBNYWZmYXksIEtsYXVzIExhZ2UsIFB1ciwgUGV0ZXIgQ29ybmVsaXVzLCBIYW5zaSBEdWptaWM8L2xpPgo8L3VsPgo8aHI+CjxoND5TQ0hBVVNQSUVMRVIgLyBGSUxNRSAvIFNFUklFTjwvaDQ+Cjx1bD4KPGxpPkplYW4gQ2xhdWRlIFZhbiBEYW1tZSwgU3lsdmVzdGVyIFN0YWxsb25lLCBTdGV2ZW4gU2VhZ2FsLCBMb3JlbnpvIExhbWFzLCBOaWNvbGFzIENhZ2UsIFJpY2hhcmQgRGVhbiBBbmRlcnNvbiwgRGVuemVsIFdhc2hpbmd0b24sIENocmlzdG9waGVyIExhbWJlcnQsIE1lZyBSeWFuLCBTYXJhaCBNaWNoZWxsZSBHZWxsYXIsIEFtYW5kYSBUYXBwaW5nIC4uLi48L2xpPgo8bGk+SyZvdW1sO25pZ3JlaWNoIGRlciBIaW1tZWwsIEhlcnIgZGVyIFJpbmdlLCBIaWdobGFuZGVyLCBDb24gQWlyLCBUaGUgUm9jaywgU3RhcmdhdGUsIEluZGVwZW5kZW5jZSBEYXksIFp1bSB0Jm91bWw7dGVuIGZyZWlnZWdlYmVuLCBIYXJkIFRvIEtpbGwsIFRoZSBQYXRyaW90LCBSYW1ibywgUm9ja3ksIEhhcnRlIFppZWxlLCBUaW1lY29wLCBCZXN0IE9mIFRoZSBCZXN0LCBCcnVjZSBMZWUgU3RvcnkgLi4uLjwvbGk+CjxsaT5TdGFyZ2F0ZSwgQW5kcm9tZWRhLCBIaWdod2F5IFRvIEhlbGwsIFJlbmVnYWRlLCBOaWtpdGEsIFByb2ZpbGVyLCBDU0ksIERhcmsgQW5nZWwsIEJ1ZmZ5LCBDaGFybWVkPC9saT4KPC91bD4KPC9kaXY+CjwvZGl2Pgo=');
8+
$after_load = (new rh_rte_helper_debug)->on_load($test_string);
9+
10+
var_dump($after_load === $test_string);
11+
12+
final class rh_rte_helper_debug
13+
{
14+
public $errors = [];
15+
16+
public function on_load(string $content): string
17+
{
18+
$content = utf8_encode($content);
19+
$content = $this->add_outer_html($content);
20+
$content = $this->remove_garbage($content);
21+
$has_root_block = $this->has_root_block($content);
22+
if(!$has_root_block)
23+
{
24+
$content = $this->add_root_block($content);
25+
}
26+
$content = $this->remove_outer_html($content);
27+
$content = mb_convert_encoding($content, 'html-entities', 'UTF-8');
28+
$content = utf8_decode($content);
29+
return $content;
30+
}
31+
32+
private function has_root_block(string $content): bool
33+
{
34+
$return = $content;
35+
$doc = $this->get_dom($content);
36+
if($doc != FALSE)
37+
{
38+
$xpath = ($doc != FALSE) ? new DomXpath($doc) : FALSE;
39+
if($xpath != FALSE)
40+
{
41+
$path = '//*[contains(concat(" ", normalize-space(@class), " "), "tinymce-generated-root-block")]';
42+
$nodes = $xpath->query($path);
43+
$nodes_idx = ($nodes != FALSE) ? $nodes->length : 0;
44+
if($nodes_idx > 0)
45+
{
46+
return TRUE;
47+
}
48+
else
49+
{
50+
return FALSE;
51+
}
52+
}
53+
else
54+
{
55+
return FALSE;
56+
}
57+
}
58+
else
59+
{
60+
return FALSE;
61+
}
62+
}
63+
64+
private function add_root_block(string $content): string
65+
{
66+
$return = $content;
67+
$doc = $this->get_dom($content);
68+
if($doc != FALSE)
69+
{
70+
$xpath = ($doc != FALSE) ? new DomXpath($doc) : FALSE;
71+
if($xpath != FALSE)
72+
{
73+
$path = '//*[contains(concat(" ", normalize-space(@class), " "), "tinymce-generated-root-block")]';
74+
$nodes = $xpath->query($path);
75+
$nodes_idx = ($nodes != FALSE) ? $nodes->length : 0;
76+
if($nodes_idx == 0)
77+
{
78+
$root_div = $doc->createElement('div');
79+
$root_div->setAttribute('class', 'tinymce-generated-root-block');
80+
$root_div->setAttribute('style', 'margin: 0px; padding: 0px;');
81+
$body = $doc->getElementsByTagName('body')->item(0);
82+
if($body !== NULL)
83+
{
84+
while($body->childNodes->length > 0)
85+
{
86+
$root_div->appendChild($body->childNodes->item(0));
87+
}
88+
$body->appendChild($root_div);
89+
$return = $doc->saveHTML();
90+
}
91+
}
92+
}
93+
}
94+
return $return;
95+
}
96+
97+
private function add_outer_html(string $content): string
98+
{
99+
return '<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd"><html><head><title>Tidy</title></head><body>' . $content . '</body></html>';
100+
}
101+
102+
private function remove_root_block(string $content): string
103+
{
104+
return $this->remove_block($content, 'tinymce-generated-root-block');
105+
}
106+
107+
private function remove_garbage(string $content): string
108+
{
109+
return $this->remove_block($content, 'tinymce-garbage-root-block');
110+
}
111+
112+
private function get_dom(string $html, bool $add_outer_html=TRUE): DOMDocument
113+
{
114+
$use_internal_errors = libxml_use_internal_errors(TRUE);
115+
$dom = new DOMDocument;
116+
$dom->resolveExternals = FALSE;
117+
$dom->preserveWhiteSpace = TRUE;
118+
$dom->strictErrorChecking = FALSE;
119+
$dom->formatOutput = TRUE;
120+
$dom->recover = TRUE;
121+
$dom->validateOnParse = TRUE;
122+
$dom->substituteEntities = FALSE;
123+
$html = mb_convert_encoding($html, 'HTML-ENTITIES', 'UTF-8');
124+
$options = 0;
125+
if(!$add_outer_html)
126+
{
127+
$options = LIBXML_HTML_NOIMPLIED;
128+
}
129+
$options = $options | LIBXML_HTML_NODEFDTD;
130+
$loaded = @$dom->loadHTML('<?xml encoding="UTF-8">' . $html, $options);
131+
if(!$loaded)
132+
{
133+
$dom = FALSE;
134+
$this->errors = libxml_get_errors();
135+
}
136+
else
137+
{
138+
foreach($dom->childNodes as $item)
139+
{
140+
if($item->nodeType == XML_PI_NODE)
141+
{
142+
$dom->removeChild($item);
143+
}
144+
}
145+
$dom->encoding = 'UTF-8';
146+
}
147+
libxml_clear_errors();
148+
libxml_use_internal_errors($use_internal_errors);
149+
return $dom;
150+
}
151+
152+
private function remove_outer_html(string $content): string
153+
{
154+
$return = $content;
155+
$doc = $this->get_dom($content);
156+
if($doc !== FALSE)
157+
{
158+
if($doc->doctype !== NULL)
159+
{
160+
$doc->doctype->parentNode->removeChild($doc->doctype);
161+
}
162+
$html = $doc->getElementsByTagName('html')->item(0);
163+
if($html !== NULL)
164+
{
165+
$fragment = $doc->createDocumentFragment();
166+
while($html->childNodes->length > 0)
167+
{
168+
$childNode = $html->childNodes->item(0);
169+
$fragment->appendChild($childNode);
170+
}
171+
$html->parentNode->replaceChild($fragment, $html);
172+
}
173+
$body = $doc->getElementsByTagName('body')->item(0);
174+
if($body !== NULL)
175+
{
176+
$return = '';
177+
$fragment = $doc->createDocumentFragment();
178+
while($body->childNodes->length > 0)
179+
{
180+
$childNode = $body->childNodes->item(0);
181+
$fragment->appendChild($childNode);
182+
$return .= $doc->saveHTML($childNode);
183+
}
184+
$body->parentNode->replaceChild($fragment, $body);
185+
}
186+
else
187+
{
188+
$return = $doc->saveHTML();
189+
}
190+
}
191+
return $return;
192+
}
193+
194+
private function remove_block(string $content, string $class='tinymce-generated-root-block'): string
195+
{
196+
$return = $content;
197+
$doc = $this->get_dom($content);
198+
if($doc != FALSE)
199+
{
200+
$xpath = ($doc != FALSE) ? new DomXpath($doc) : FALSE;
201+
if($xpath != FALSE)
202+
{
203+
$path = '//*[contains(concat(" ", normalize-space(@class), " "), "'.$class.'")]';
204+
$nodes = $xpath->query($path);
205+
$nodes_idx = ($nodes != FALSE) ? $nodes->length : 0;
206+
if($nodes_idx > 0)
207+
{
208+
foreach($nodes as $node)
209+
{
210+
$fragment = $doc->createDocumentFragment();
211+
while($node->childNodes->length > 0)
212+
{
213+
$childNode = $node->childNodes->item(0);
214+
if($childNode->nodeType == XML_TEXT_NODE)
215+
{
216+
$fragment->appendChild($doc->createTextNode($childNode->nodeValue));
217+
$childNode->parentNode->removeChild($childNode);
218+
}
219+
else
220+
{
221+
$fragment->appendChild($childNode);
222+
}
223+
}
224+
$node->parentNode->replaceChild($fragment, $node);
225+
}
226+
$return = $doc->saveHTML();
227+
}
228+
}
229+
}
230+
return $return;
231+
}
232+
}
233+
--EXPECT--
234+
bool(true)

0 commit comments

Comments
 (0)