Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix uninitialized variable accesses in sockets/conversions
This was first pointed out in GH-10959. The from_zval_... functions don't always write to the pointer, in particular it is necessary to check for an error before using the value. Otherwise we can access an uninitialized value and that's UB (and dangerous). Note: this does *NOT* get rid of the compiler warning. Even though there is error checking now, the compiler isn't smart enough to figure out that the values can not be used uninitialized. Closes GH-10966.
- Loading branch information