Skip to content

Commit b891ade

Browse files
committed
Don't suppress notices in rfc1867 tests
The references notices in debug builds don't seem to be present anymore.
1 parent c169819 commit b891ade

13 files changed

+12
-38
lines changed

ext/session/tests/rfc1867.phpt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
session rfc1867
33
--INI--
44
file_uploads=1
5-
error_reporting=E_ALL&~E_NOTICE
6-
comment=debug builds show some additional E_NOTICE errors
75
upload_max_filesize=1024
86
session.save_path=
97
session.name=PHPSESSID

ext/session/tests/rfc1867_cleanup.phpt

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
session rfc1867
33
--INI--
44
file_uploads=1
5-
error_reporting=E_ALL&~E_NOTICE
6-
comment=debug builds show some additional E_NOTICE errors
75
upload_max_filesize=1024
86
session.save_path=
97
session.name=PHPSESSID
@@ -48,7 +46,7 @@ session_start();
4846
var_dump(session_id());
4947
var_dump(basename(__FILE__) == $_POST[ini_get("session.upload_progress.name")]);
5048
var_dump($_FILES);
51-
var_dump($_SESSION["upload_progress_" . basename(__FILE__)]);
49+
var_dump(isset($_SESSION["upload_progress_" . basename(__FILE__)]));
5250
session_destroy();
5351
?>
5452
--EXPECTF--
@@ -82,4 +80,4 @@ array(2) {
8280
int(1)
8381
}
8482
}
85-
NULL
83+
bool(false)

ext/session/tests/rfc1867_disabled.phpt

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
session rfc1867 disabled
33
--INI--
44
file_uploads=1
5-
error_reporting=E_ALL&~E_NOTICE
6-
comment=debug builds show some additional E_NOTICE errors
75
upload_max_filesize=1024
86
session.save_path=
97
session.name=PHPSESSID
@@ -42,7 +40,7 @@ Content-Disposition: form-data; name="file2"; filename="file2.txt"
4240
session_start();
4341
var_dump(session_id());
4442
var_dump($_FILES);
45-
var_dump($_SESSION["upload_progress_" . basename(__FILE__)]);
43+
var_dump(isset($_SESSION["upload_progress_" . basename(__FILE__)]));
4644
session_destroy();
4745
?>
4846
--EXPECTF--
@@ -75,4 +73,4 @@ array(2) {
7573
int(1)
7674
}
7775
}
78-
NULL
76+
bool(false)

ext/session/tests/rfc1867_disabled_2.phpt

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
session rfc1867 disabled 2
33
--INI--
44
file_uploads=1
5-
error_reporting=E_ALL&~E_NOTICE
6-
comment=debug builds show some additional E_NOTICE errors
75
upload_max_filesize=1024
86
session.save_path=
97
session.name=PHPSESSID
@@ -42,7 +40,7 @@ Content-Disposition: form-data; name="file2"; filename="file2.txt"
4240
session_start();
4341
var_dump(session_id());
4442
var_dump($_FILES);
45-
var_dump($_SESSION["upload_progress_" . basename(__FILE__)]);
43+
var_dump(isset($_SESSION["upload_progress_" . basename(__FILE__)]));
4644
session_destroy();
4745
?>
4846
--EXPECTF--
@@ -75,4 +73,4 @@ array(2) {
7573
int(1)
7674
}
7775
}
78-
NULL
76+
bool(false)

ext/session/tests/rfc1867_inter.phpt

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
session rfc1867
33
--INI--
44
file_uploads=1
5-
error_reporting=E_ALL&~E_NOTICE
6-
comment=debug builds show some additional E_NOTICE errors
75
upload_max_filesize=1024
86
session.save_path=
97
session.name=PHPSESSID
@@ -52,7 +50,7 @@ session_start();
5250
var_dump(session_id());
5351
var_dump($_FILES);
5452
var_dump($_SESSION["upload_progress_" . basename(__FILE__) . "_1"]);
55-
var_dump($_SESSION["upload_progress_" . basename(__FILE__) . "_2"]);
53+
var_dump(isset($_SESSION["upload_progress_" . basename(__FILE__) . "_2"]));
5654
session_destroy();
5755
?>
5856
--EXPECTF--
@@ -132,4 +130,4 @@ array(5) {
132130
}
133131
}
134132
}
135-
NULL
133+
bool(false)

ext/session/tests/rfc1867_no_name.phpt

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
session rfc1867 no name
33
--INI--
44
file_uploads=1
5-
error_reporting=E_ALL&~E_NOTICE
6-
comment=debug builds show some additional E_NOTICE errors
75
upload_max_filesize=1024
86
session.save_path=
97
session.name=PHPSESSID
@@ -42,7 +40,7 @@ Content-Disposition: form-data; name="file2"; filename="file2.txt"
4240
session_start();
4341
var_dump(session_id());
4442
var_dump($_FILES);
45-
var_dump($_SESSION["upload_progress_" . basename(__FILE__)]);
43+
var_dump(isset($_SESSION["upload_progress_" . basename(__FILE__)]));
4644
session_destroy();
4745
?>
4846
--EXPECTF--
@@ -75,4 +73,4 @@ array(2) {
7573
int(1)
7674
}
7775
}
78-
NULL
76+
bool(false)

ext/session/tests/rfc1867_sid_cookie.phpt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
session rfc1867 sid cookie
33
--INI--
44
file_uploads=1
5-
error_reporting=E_ALL&~E_NOTICE
6-
comment=debug builds show some additional E_NOTICE errors
75
upload_max_filesize=1024
86
session.save_path=
97
session.name=PHPSESSID

ext/session/tests/rfc1867_sid_get.phpt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
session rfc1867 sid get
33
--INI--
44
file_uploads=1
5-
error_reporting=E_ALL&~E_NOTICE
6-
comment=debug builds show some additional E_NOTICE errors
75
upload_max_filesize=1024
86
session.save_path=
97
session.name=PHPSESSID

ext/session/tests/rfc1867_sid_get_2.phpt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
session rfc1867 sid get 2
33
--INI--
44
file_uploads=1
5-
error_reporting=E_ALL&~E_NOTICE
6-
comment=debug builds show some additional E_NOTICE errors
75
upload_max_filesize=1024
86
session.save_path=
97
session.name=PHPSESSID

ext/session/tests/rfc1867_sid_invalid.phpt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
session rfc1867 sid cookie
33
--INI--
44
file_uploads=1
5-
error_reporting=E_ALL&~E_NOTICE
6-
comment=debug builds show some additional E_NOTICE errors
75
upload_max_filesize=1024
86
session.save_path=
97
session.name=PHPSESSID

0 commit comments

Comments
 (0)