fix segfault in ZEND_FUNC_GET_ARGS
#12768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case a `ZEND_BIND_STATIC` is being executed, while the current chunk is full, the `zend_array_dup()` call will trigger a OOM in ZendMM which will crash, as the opline might be a dangling pointer.
In case a `ZEND_FUNC_GET_ARGS` is being executed, while the current chunk is full, the `zend_new_array()` call will trigger a OOM in ZendMM which will crash, as the opline might be a dangling pointer.
realFlowControl
force-pushed
the
fix-opline-for-func-get-args
branch
from
1cf0bcb
to
8a73bb5
Compare
bwoebi
added a commit
that referenced
this pull request
Nov 24, 2023
|
This approach doesn't seem to work for |
|
@iluuu1994 can we explicitly set USE_ZEND_ALLOC=1 in the test via --ENV--? |
|
@bwoebi That should probably work. |
|
Yes, I too think that this should work. Is it okay if I have a look on Monday? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the work of #12758 (which should be merged before this one, as it contains all the work on
zend_test)In case a
ZEND_FUNC_GET_ARGSis being executed, while the current chunk is full, thezend_new_array()call will trigger a OOM in ZendMM which will crash, as the opline might be a dangling pointer.Commit 8a73bb5 brings the test and the fix