Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify FPM ACL check #13604

Merged
merged 2 commits into from Mar 8, 2024
Merged

Simplify FPM ACL check #13604

merged 2 commits into from Mar 8, 2024

Conversation

petk
Copy link
Member

@petk petk commented Mar 6, 2024

Instead of running the user/group permissions check (unknown when cross-compiling), check with linking (AC_LINK_IFELSE) can be sufficient to test if ACL_USER and ACL_GROUP are available (missing on macOS). The AC_SEARCH_LIBS is used to test the ACL availability in c or acl library.

Instead of running the user/group permissions check (unknown when
cross-compiling), check with linking (AC_LINK_IFELSE) can be sufficient
to test if ACL_USER and ACL_GROUP are available (missing on macOS). The
AC_SEARCH_LIBS is used to test the ACL availability in c or acl library.
sapi/fpm/config.m4 Outdated Show resolved Hide resolved
sapi/fpm/config.m4 Outdated Show resolved Hide resolved
Copy link
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense

@petk petk merged commit 1dfba42 into php:master Mar 8, 2024
7 of 10 checks passed
@petk petk deleted the patch-fpm-acl branch March 8, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants