[Draft][Require RFC] Add grapheme_levenshtein function. #16428
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youkidearitai
force-pushed
the
grapheme_levenshtein
branch
from
9a476f2 to
9b97ea5
Compare
Measure levenshtein for grapheme cluster unit
youkidearitai
force-pushed
the
grapheme_levenshtein
branch
from
9b97ea5 to
d784874
Compare
|
I'm sorry. I will close this PR. |
derickr
reviewed
Apr 7, 2025
|
|
||
| intl_convert_utf8_to_utf16(&ustring1, &ustring1_len, pstr1, ZSTR_LEN(string1), &ustatus1); | ||
|
|
||
| if ( U_FAILURE( ustatus1 ) ) { |
There was a problem hiding this comment.
We don't usually add spaces between ( and it's contents, like:
if (U_FAILURE(ustatus1)) {
|
|
||
| if ( U_FAILURE( ustatus1 ) ) { | ||
| /* Set global error code. */ | ||
| intl_error_set_code( NULL, ustatus1 ); |
There was a problem hiding this comment.
Also here, and in my other situations in this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #16043
mbstring based levenshtein function is codepoint unit.
However, codepoint unit can not measure combined character, variable selector and etc...
So I create measure levenshtein for grapheme cluster unit.
RFC: https://wiki.php.net/rfc/grapheme_levenshtein