Change PHP_ZTS and PHP_DEBUG to bool to match their ZEND equivalents #13079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
approved these changes
Jan 6, 2024
Would this fall under 'Core' in NEWS and 'Other Changes' or 'Backward Incompatible Changes' in UPGRADING? |
|
I went with 'Core' and 'Backward Incompatible Changes'. |
Girgias
approved these changes
Jan 7, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constants ZEND_THREAD_SAFE and PHP_ZTS, and ZEND_DEBUG_BUILD and PHP_DEBUG are based on the same underlying values (the values of ZTS and ZEND_DEBUG respectively). Despite this, the ZEND constants are bool while their PHP equivalents are int. This PR aims to change these aliases to be of the same type, bool.
php-src included one test file that used a loose comparison with PHP_ZTS which this PR also updates to use the same format other comparisons with this constant use (i.e
if (PHP_ZTS)/if (!PHP_ZTS)).