Add hosted docs link to docs/README.md #13633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
reviewed
Mar 8, 2024
iluuu1994
reviewed
Mar 8, 2024
docs/README.md
Outdated
| @@ -1,6 +1,7 @@ | |||
| # php-src docs | |||
|
|
|||
| This is the home of the php-src internal documentation. It is in very early stages, but is intended | |||
| This is the home of the php-src internal documentation, hosted at | |||
| [php.github.io/php-src/](https://php.github.io/php-src/). It is in very early stages, but is intended | |||
There was a problem hiding this comment.
Sorry to be pedantic, these are 101 characters 🙂
There was a problem hiding this comment.
there were another line over 100 chars
I wonder a little why 100 is the limit instead of typical 120 chars
There was a problem hiding this comment.
No special reason, just personal preference. I find it better for readability than 120 while not as extreme as 80.
|
Thanks @mvorisek! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know the link is also in the main README, but for me, it is very logical to have a hosted link in docs/ which is the place I naturally open when I am looking for docs.