Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GH-14290: Member access within null pointer in extension spl #14292

Closed
wants to merge 1 commit into from
Closed

Fix GH-14290: Member access within null pointer in extension spl #14292

wants to merge 1 commit into from

Commits on May 21, 2024

  1. Fix phpGH-14290: Member access within null pointer in extension spl 

    php_pcre_replace_impl() can fail and return NULL. We should take that
error condition into account. Because other failures return false, we
return false here as well.

At first, I also thought there was a potential memory leak in the error
check of replacement_str, but found that the error condition can never
trigger, so replace that with an assertion.
    @nielsdos
    nielsdos committed May 21, 2024
    Configuration menu
    Copy the full SHA
    f848507 View commit details
    Browse the repository at this point in the history