Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ext/fileinfo/generate_patch.sh simpler to use #14941

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

petk
Copy link
Member

@petk petk commented Jul 13, 2024

  • Shebang added so it can be called with ./generate_patch.sh
  • Script changes its working directory to ext/fileinfo (where it is located) so it can be also called as ./ext/fileinfo/generate_patch.sh
  • Syntax adjusted a bit for using Bourne or a compatible shell (/bin/sh)
  • Downloaded files added to .gitignore

- Shebang added so it can be called with ./generate_patch.sh
- Script changes its working directory to ext/fileinfo (where it is
  located) so it can be also called as ./ext/fileinfo/generate_patch.sh
- Syntax adjusted a bit for using Bourne or a compatible shell (/bin/sh)
- Downloaded files added to .gitignore
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this should simplify it a bit, I remember the working dir and gitignore being really annoying when I did the upgrade. Thanks for this!

@petk petk merged commit 31a21bb into php:master Jul 13, 2024
11 checks passed
@petk petk deleted the patch-fileinfo-generate-patch branch July 13, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants