Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IS_STATIC_VAR_UNINITIALIZED #15227

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

iluuu1994
Copy link
Member

This flag was never necessary. We know a static variable is uninitialized (i.e. the initializer has never been called) iff the zval in the static variable array does not contain a reference.

Prompted by a related issue in ext-uopz reported by Christoph.

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks like a nice conceptual simplification, and apparently won't break anything – as such a good idea!

This flag was never necessary. We know a static variable is uninitialized (i.e.
the initializer has never been called) iff the zval in the static variable array
does not contain a reference.

Prompted by a related issue in ext-uopz reported by Christoph.
@iluuu1994 iluuu1994 force-pushed the remove-IS_STATIC_VAR_UNINITIALIZED branch from 1ab6af4 to 629ee93 Compare August 5, 2024 09:18
@iluuu1994 iluuu1994 merged commit 50217b3 into php:master Aug 5, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants